All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP
Date: Fri, 14 Nov 2014 21:47:11 +0300	[thread overview]
Message-ID: <54664E2F.6070701@cogentembedded.com> (raw)
In-Reply-To: <1415978763-27345-12-git-send-email-antoine.tenart@free-electrons.com>

Hello.

On 11/14/2014 06:26 PM, Antoine Tenart wrote:

> Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q
> DMP.

> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>   arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++++++++++++++++++++++++++++++
>   1 file changed, 53 insertions(+)

> diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> index ea1f99b8eed6..f7c25580e122 100644
> --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
[...]
> @@ -21,6 +23,39 @@
>   	choosen {
>   		bootargs = "console=ttyS0,115200 earlyprintk";
>   	};
> +
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		reg_usb0_vbus: regulator at 0 {

    Erm, I'm not seeing the "reg" prop. The <unit-address> part of the name 
shouldn't be used without the "reg" prop.

[...]

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
	sebastian.hesselbarth@gmail.com, Peter.Chen@freescale.com,
	balbi@ti.com, p.zabel@pengutronix.de
Cc: alexandre.belloni@free-electrons.com,
	thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
	jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP
Date: Fri, 14 Nov 2014 21:47:11 +0300	[thread overview]
Message-ID: <54664E2F.6070701@cogentembedded.com> (raw)
In-Reply-To: <1415978763-27345-12-git-send-email-antoine.tenart@free-electrons.com>

Hello.

On 11/14/2014 06:26 PM, Antoine Tenart wrote:

> Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q
> DMP.

> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>   arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++++++++++++++++++++++++++++++
>   1 file changed, 53 insertions(+)

> diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> index ea1f99b8eed6..f7c25580e122 100644
> --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
[...]
> @@ -21,6 +23,39 @@
>   	choosen {
>   		bootargs = "console=ttyS0,115200 earlyprintk";
>   	};
> +
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		reg_usb0_vbus: regulator@0 {

    Erm, I'm not seeing the "reg" prop. The <unit-address> part of the name 
shouldn't be used without the "reg" prop.

[...]

WBR, Sergei

  reply	other threads:[~2014-11-14 18:47 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 15:25 [PATCH v7 00/13] ARM: berlin: USB support Antoine Tenart
2014-11-14 15:25 ` Antoine Tenart
2014-11-14 15:25 ` [PATCH v7 01/13] reset: add the Berlin reset controller driver Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25 ` [PATCH v7 02/13] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25 ` [PATCH v7 03/13] ARM: Berlin: select the reset controller Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:33   ` Arnd Bergmann
2014-11-14 15:33     ` Arnd Bergmann
2014-11-14 15:33     ` Arnd Bergmann
2014-11-14 15:36     ` Sebastian Hesselbarth
2014-11-14 15:36       ` Sebastian Hesselbarth
2014-11-14 15:36       ` Sebastian Hesselbarth
2014-11-14 17:28       ` Antoine Tenart
2014-11-14 17:28         ` Antoine Tenart
2014-11-14 17:28         ` Antoine Tenart
2014-11-14 19:07         ` Sebastian Hesselbarth
2014-11-14 19:07           ` Sebastian Hesselbarth
2014-11-14 15:25 ` [PATCH v7 04/13] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25 ` [PATCH v7 05/13] phy: add the Berlin USB PHY driver Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25 ` [PATCH v7 06/13] Documentation: bindings: add doc for the Berlin USB PHY Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25 ` [PATCH v7 07/13] usb: chipidea: fix phy handling Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-17  5:53   ` Peter Chen
2014-11-17  5:53     ` Peter Chen
2014-11-17  5:53     ` Peter Chen
2014-11-14 15:25 ` [PATCH v7 08/13] usb: chipidea: add a usb2 driver for ci13xxx Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-14 21:08   ` Felipe Balbi
2014-11-14 21:08     ` Felipe Balbi
2014-11-14 21:08     ` Felipe Balbi
2014-11-14 21:10     ` Antoine Tenart
2014-11-14 21:10       ` Antoine Tenart
2014-11-14 21:10       ` Antoine Tenart
2014-11-14 21:13       ` Felipe Balbi
2014-11-14 21:13         ` Felipe Balbi
2014-11-14 21:13         ` Felipe Balbi
2014-11-17 10:01         ` Antoine Tenart
2014-11-17 10:01           ` Antoine Tenart
2014-11-17 10:01           ` Antoine Tenart
2014-11-17  5:40   ` Peter Chen
2014-11-17  5:40     ` Peter Chen
2014-11-17  5:40     ` Peter Chen
2014-11-14 15:25 ` [PATCH v7 09/13] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Tenart
2014-11-14 15:25   ` Antoine Tenart
2014-11-17  5:54   ` Peter Chen
2014-11-17  5:54     ` Peter Chen
2014-11-17  5:54     ` Peter Chen
2014-11-14 15:26 ` [PATCH v7 10/13] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Tenart
2014-11-14 15:26   ` Antoine Tenart
2014-11-14 15:26 ` [PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Tenart
2014-11-14 15:26   ` Antoine Tenart
2014-11-14 18:47   ` Sergei Shtylyov [this message]
2014-11-14 18:47     ` Sergei Shtylyov
2014-11-14 21:14     ` Antoine Tenart
2014-11-14 21:14       ` Antoine Tenart
2014-11-14 15:26 ` [PATCH v7 12/13] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Tenart
2014-11-14 15:26   ` Antoine Tenart
2014-11-14 15:26 ` [PATCH v7 13/13] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Tenart
2014-11-14 15:26   ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54664E2F.6070701@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.