From: Alex Elder <elder@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: akpm@linux-foundation.org, bobby.prani@gmail.com,
pmladek@suse.cz, jack@suse.cz, mcgrof@suse.com, joe@perches.com,
linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] printk: drop logbuf_cpu volatile qualifier
Date: Fri, 14 Nov 2014 13:46:44 -0600 [thread overview]
Message-ID: <54665C24.9060605@linaro.org> (raw)
In-Reply-To: <20141114144515.5b3e7d32@gandalf.local.home>
On 11/14/2014 01:45 PM, Steven Rostedt wrote:
> On Fri, 14 Nov 2014 13:19:31 -0600
> Alex Elder <elder@linaro.org> wrote:
>
>> Pranith Kumar posted a patch in which removed the "volatile"
>> qualifier for the "logbuf_cpu" variable in vprintk_emit().
>> https://lkml.org/lkml/2014/11/13/894
>> In his patch, he used ACCESS_ONCE() for all references to
>> that symbol to provide whatever protection was intended.
>>
>> There was some discussion that followed, and in the end
>> Stephen Rostedt concluded that not only was "volatile" not
>
> I don't know of a Stephen Rostedt. J
Sorry. I'm sure that's a source of annoyance. -Alex
>> needed, neither was it required to use ACCESS_ONCE(). I
>> offered an elaborate description that concluded Stephen
>
> Who is this Stephen you talk about?
. . .
next prev parent reply other threads:[~2014-11-14 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 19:19 [PATCH] printk: drop logbuf_cpu volatile qualifier Alex Elder
2014-11-14 19:45 ` Steven Rostedt
2014-11-14 19:46 ` Alex Elder [this message]
2014-11-14 19:55 ` Steven Rostedt
2014-11-14 20:01 ` Alex Elder
2014-11-18 9:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54665C24.9060605@linaro.org \
--to=elder@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.