From: Antti Palosaari <crope@iki.fi>
To: CrazyCat <crazycat69@narod.ru>,
linux-media <linux-media@vger.kernel.org>,
Olli Salonen <olli.salonen@iki.fi>
Subject: Re: [PATCH 1/3] tuners: si2157: Si2148 support.
Date: Sat, 15 Nov 2014 03:01:58 +0200 [thread overview]
Message-ID: <5466A606.8030805@iki.fi> (raw)
In-Reply-To: <1918522.5V5b9CGsli@computer>
Hello
I wonder if we should define own firmware for Si2148-A20 just for sure.
Olli?
regards
Antti
On 11/14/2014 11:19 PM, CrazyCat wrote:
> Si2148-A20 silicon tuner support.
>
> Signed-off-by: Evgeny Plehov <EvgenyPlehov@ukr.net>
> ---
> drivers/media/tuners/si2157.c | 10 ++++++----
> drivers/media/tuners/si2157.h | 2 +-
> drivers/media/tuners/si2157_priv.h | 2 +-
> 3 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
> index 25146fa..91f8290 100644
> --- a/drivers/media/tuners/si2157.c
> +++ b/drivers/media/tuners/si2157.c
> @@ -1,5 +1,5 @@
> /*
> - * Silicon Labs Si2147/2157/2158 silicon tuner driver
> + * Silicon Labs Si2147/2148/2157/2158 silicon tuner driver
> *
> * Copyright (C) 2014 Antti Palosaari <crope@iki.fi>
> *
> @@ -112,11 +112,13 @@ static int si2157_init(struct dvb_frontend *fe)
> cmd.args[4] << 0;
>
> #define SI2158_A20 ('A' << 24 | 58 << 16 | '2' << 8 | '0' << 0)
> + #define SI2148_A20 ('A' << 24 | 48 << 16 | '2' << 8 | '0' << 0)
> #define SI2157_A30 ('A' << 24 | 57 << 16 | '3' << 8 | '0' << 0)
> #define SI2147_A30 ('A' << 24 | 47 << 16 | '3' << 8 | '0' << 0)
>
> switch (chip_id) {
> case SI2158_A20:
> + case SI2148_A20:
> fw_file = SI2158_A20_FIRMWARE;
> break;
> case SI2157_A30:
> @@ -309,7 +311,7 @@ static int si2157_get_if_frequency(struct dvb_frontend *fe, u32 *frequency)
>
> static const struct dvb_tuner_ops si2157_ops = {
> .info = {
> - .name = "Silicon Labs Si2157/Si2158",
> + .name = "Silicon Labs Si2147/2148/2157/Si2158",
> .frequency_min = 110000000,
> .frequency_max = 862000000,
> },
> @@ -373,7 +375,7 @@ static int si2157_probe(struct i2c_client *client,
> i2c_set_clientdata(client, s);
>
> dev_info(&s->client->dev,
> - "Silicon Labs Si2157/Si2158 successfully attached\n");
> + "Silicon Labs Si2147/2148/2157/Si2158 successfully attached\n");
> return 0;
> err:
> dev_dbg(&client->dev, "failed=%d\n", ret);
> @@ -414,7 +416,7 @@ static struct i2c_driver si2157_driver = {
>
> module_i2c_driver(si2157_driver);
>
> -MODULE_DESCRIPTION("Silicon Labs Si2157/Si2158 silicon tuner driver");
> +MODULE_DESCRIPTION("Silicon Labs Si2147/2148/2157/Si2158 silicon tuner driver");
> MODULE_AUTHOR("Antti Palosaari <crope@iki.fi>");
> MODULE_LICENSE("GPL");
> MODULE_FIRMWARE(SI2158_A20_FIRMWARE);
> diff --git a/drivers/media/tuners/si2157.h b/drivers/media/tuners/si2157.h
> index d3b19ca..c439d0e 100644
> --- a/drivers/media/tuners/si2157.h
> +++ b/drivers/media/tuners/si2157.h
> @@ -1,5 +1,5 @@
> /*
> - * Silicon Labs Si2147/2157/2158 silicon tuner driver
> + * Silicon Labs Si2147/2148/2157/2158 silicon tuner driver
> *
> * Copyright (C) 2014 Antti Palosaari <crope@iki.fi>
> *
> diff --git a/drivers/media/tuners/si2157_priv.h b/drivers/media/tuners/si2157_priv.h
> index e71ffaf..6d2aac4 100644
> --- a/drivers/media/tuners/si2157_priv.h
> +++ b/drivers/media/tuners/si2157_priv.h
> @@ -1,5 +1,5 @@
> /*
> - * Silicon Labs Si2147/2157/2158 silicon tuner driver
> + * Silicon Labs Si2147/2148/2157/2158 silicon tuner driver
> *
> * Copyright (C) 2014 Antti Palosaari <crope@iki.fi>
> *
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-11-15 1:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 21:19 [PATCH 1/3] tuners: si2157: Si2148 support CrazyCat
2014-11-15 1:01 ` Antti Palosaari [this message]
2014-11-15 1:22 ` CrazyCat
2014-11-15 1:36 ` Antti Palosaari
2014-11-15 10:41 ` Olli Salonen
2014-11-15 11:02 ` Antti Palosaari
2014-11-15 12:33 ` Olli Salonen
[not found] <CA++x_yD6oxb4mkbP_8UtHU13LM5dgacbtHXWKe+qpDEfFp5bMw@mail.gmail.com>
2014-11-17 16:10 ` Michael Holzer
2014-11-20 20:10 ` Olli Salonen
2014-11-20 21:07 ` CrazyCat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5466A606.8030805@iki.fi \
--to=crope@iki.fi \
--cc=crazycat69@narod.ru \
--cc=linux-media@vger.kernel.org \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.