All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <B51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx:mx6sxsabresd fix pfuz probe failed
Date: Sun, 16 Nov 2014 19:42:17 +0800	[thread overview]
Message-ID: <54688D99.8010708@freescale.com> (raw)
In-Reply-To: <CAOMZO5Ckp9dUCOj2Uyptj9U2oYTGThqAPKsx13bn6etuSm3CKQ@mail.gmail.com>

Hi Stefano,

Would you please help reviewing this patch?

On 11/1/2014 8:16 AM, Fabio Estevam wrote:
> On Fri, Oct 31, 2014 at 1:08 AM, Peng Fan <Peng.Fan@freescale.com> wrote:
>> The PFUZ probe failed with the following msg:
>> " wait_for_sr_state: failed sr=81 cr=a0 state=2020
>>    i2c_init_transfer: failed for chip 0x8 retry=0
>>    wait_for_sr_state: failed sr=81 cr=a0 state=2020
>>    i2c_init_transfer: failed for chip 0x8 retry=1
>>    wait_for_sr_state: failed sr=81 cr=a0 state=2020
>>    i2c_init_transfer: failed for chip 0x8 retry=2
>>    i2c_init_transfer: give up i2c_regs=021a0000
>>    Can't find PMIC:PFUZE100 "
>>
>> board_early_init_f is too early to call i2c related setting, because
>> init_func_i2c is called after board_early_init_f being invoked. Thus
>> move setup_i2c into board_init.
>>
>> Also PFUZ is connected to I2C bus 0, so change "1" -> "0".
>>
>> Using this patch PFUZ can be correctly probed:
>> "PMIC:  PFUZE100 ID=0x11"
>>
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
>
> Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
>
Regards,
Peng.

  reply	other threads:[~2014-11-16 11:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  3:08 [U-Boot] [PATCH] imx:mx6sxsabresd fix pfuz probe failed Peng Fan
2014-10-31 12:01 ` Fabio Estevam
2014-11-01  0:01   ` Peng Fan
2014-11-01  0:16     ` Fabio Estevam
2014-11-01  0:16 ` Fabio Estevam
2014-11-16 11:42   ` Peng Fan [this message]
2014-11-17 12:24     ` Stefano Babic
2014-11-20  9:33 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54688D99.8010708@freescale.com \
    --to=b51431@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.