All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v1 3/4] iio: gyro: bmg160: Send x, y and z motion separately
Date: Sun, 16 Nov 2014 20:21:04 +0000	[thread overview]
Message-ID: <54690730.5070502@kernel.org> (raw)
In-Reply-To: <1412998408-31870-4-git-send-email-srinivas.pandruvada@linux.intel.com>

On 11/10/14 04:33, Srinivas Pandruvada wrote:
> This chip is capable to identify motion across x, y and z axes. So
> send different events.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Taking the view this is an ABI 'fix' and applying it to the fixes-togreg branch
of iio.git

Thanks

Jonathan
> ---
>  drivers/iio/gyro/bmg160.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c
> index fa2e376..9f751d6 100644
> --- a/drivers/iio/gyro/bmg160.c
> +++ b/drivers/iio/gyro/bmg160.c
> @@ -85,6 +85,9 @@
>  
>  #define BMG160_REG_INT_STATUS_2	0x0B
>  #define BMG160_ANY_MOTION_MASK		0x07
> +#define BMG160_ANY_MOTION_BIT_X		BIT(0)
> +#define BMG160_ANY_MOTION_BIT_Y		BIT(1)
> +#define BMG160_ANY_MOTION_BIT_Z		BIT(2)
>  
>  #define BMG160_REG_TEMP		0x08
>  #define BMG160_TEMP_CENTER_VAL		23
> @@ -929,10 +932,24 @@ static irqreturn_t bmg160_event_handler(int irq, void *private)
>  	else
>  		dir = IIO_EV_DIR_FALLING;
>  
> -	if (ret & BMG160_ANY_MOTION_MASK)
> +	if (ret & BMG160_ANY_MOTION_BIT_X)
>  		iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ANGL_VEL,
>  							0,
> -							IIO_MOD_X_OR_Y_OR_Z,
> +							IIO_MOD_X,
> +							IIO_EV_TYPE_ROC,
> +							dir),
> +							data->timestamp);
> +	if (ret & BMG160_ANY_MOTION_BIT_Y)
> +		iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ANGL_VEL,
> +							0,
> +							IIO_MOD_Y,
> +							IIO_EV_TYPE_ROC,
> +							dir),
> +							data->timestamp);
> +	if (ret & BMG160_ANY_MOTION_BIT_Z)
> +		iio_push_event(indio_dev, IIO_MOD_EVENT_CODE(IIO_ANGL_VEL,
> +							0,
> +							IIO_MOD_Z,
>  							IIO_EV_TYPE_ROC,
>  							dir),
>  							data->timestamp);
> 


  reply	other threads:[~2014-11-16 20:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11  3:33 [PATCH v1 0/4] BMG160 updates Srinivas Pandruvada
2014-10-11  3:33 ` [PATCH v1 1/4] iio: gyro: bmg160: Error handling when mode set fails Srinivas Pandruvada
2014-11-16 20:19   ` Jonathan Cameron
2014-10-11  3:33 ` [PATCH v1 2/4] iio: gyro: bmg160: Don't let interrupt mode to be open drain Srinivas Pandruvada
2014-11-16 20:20   ` Jonathan Cameron
2014-10-11  3:33 ` [PATCH v1 3/4] iio: gyro: bmg160: Send x, y and z motion separately Srinivas Pandruvada
2014-11-16 20:21   ` Jonathan Cameron [this message]
2014-10-11  3:33 ` [PATCH v1 4/4] iio: gyro: bmg160: Fix iio_event_spec direction Srinivas Pandruvada
2014-11-16 20:21   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54690730.5070502@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.