From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v1 3/4] iio: accel: bmc150: set low default thresholds
Date: Sun, 16 Nov 2014 20:24:56 +0000 [thread overview]
Message-ID: <54690818.2000700@kernel.org> (raw)
In-Reply-To: <1412998534-31971-4-git-send-email-srinivas.pandruvada@linux.intel.com>
On 11/10/14 04:35, Srinivas Pandruvada wrote:
> Set the threshold to low by default. With this thresholds any movement
> on the device with this sensor will generate event.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
This is a slightly odd one. It's not technically a 'fix' but rather a
change of default behaviour. I'll take the view the previous version
was not intuitive so this is preferred and apply it to the fixes-togreg
branch of iio.git.
Jonathan
> ---
> drivers/iio/accel/bmc150-accel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> index c6df8ee..969cb21 100644
> --- a/drivers/iio/accel/bmc150-accel.c
> +++ b/drivers/iio/accel/bmc150-accel.c
> @@ -95,9 +95,9 @@
> #define BMC150_ACCEL_SLOPE_THRES_MASK 0xFF
>
> /* Slope duration in terms of number of samples */
> -#define BMC150_ACCEL_DEF_SLOPE_DURATION 2
> +#define BMC150_ACCEL_DEF_SLOPE_DURATION 1
> /* in terms of multiples of g's/LSB, based on range */
> -#define BMC150_ACCEL_DEF_SLOPE_THRESHOLD 5
> +#define BMC150_ACCEL_DEF_SLOPE_THRESHOLD 1
>
> #define BMC150_ACCEL_REG_XOUT_L 0x02
>
>
next prev parent reply other threads:[~2014-11-16 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 3:35 [PATCH v1 0/4] BMC 150 driver updates Srinivas Pandruvada
2014-10-11 3:35 ` [PATCH v1 1/4] iio: accel: bmc150: Error handling when mode set fails Srinivas Pandruvada
2014-11-16 20:23 ` Jonathan Cameron
2014-10-11 3:35 ` [PATCH v1 2/4] iio: accel: bmc150: Send x, y and z motion separately Srinivas Pandruvada
2014-11-16 20:23 ` Jonathan Cameron
2014-10-11 3:35 ` [PATCH v1 3/4] iio: accel: bmc150: set low default thresholds Srinivas Pandruvada
2014-11-16 20:24 ` Jonathan Cameron [this message]
2014-10-11 3:35 ` [PATCH v1 4/4] iio: accel: bmc150: Fix iio_event_spec direction Srinivas Pandruvada
2014-11-16 20:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54690818.2000700@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.