Re: [PATCH] 0001-xilinx-xadc-core-Fix-voltage-offset.patch

[Lars-Peter Clausen <lars@metafoo.de>]

On 11/16/2014 09:29 PM, Jonathan Cameron wrote:
> On 06/11/14 16:25, Lars-Peter Clausen wrote:
>> On 11/06/2014 05:18 PM, Fabien Proriol wrote:
>>> On 06/11/2014 16:44, Lars-Peter Clausen wrote:
>>>> On 11/06/2014 04:33 PM, Fabien Proriol wrote:
>>>>>     From 3f57e39e3c69476513c00cd5ec45703f58334972 Mon Sep 17 00:00:00 2001
>>>>> From: Fabien Proriol <fabien.proriol@jdsu.com>
>>>>> Date: Tue, 4 Nov 2014 17:05:59 +0100
>>>>> Subject: [PATCH] xilinx-xadc-core: Fix voltage offset
>>>>>
>>>>> When xilinx-xadc is used with hwmon driver to read voltage, offset used
>>>>> for temperature is always apply.
>>>>> This patch change the return for IIO_CHAN_INFO_OFFSET to -EINVAL except
>>>>> for temperature to avoid offset.
>>>>
>>>> I think we should rather fix iio_channel_read() to check if the
>>>> channel supports the property that we try to read. Other drivers are
>>>> likely to suffer from the same issue and fixing it in a central place
>>>> fixes them all.
>>>>
>>>> - Lars
>>>>
>>>>
>>>
>>> Ok, I can propose this following patch.
>>> With my xilinx-xadc driver, it fix also the same problem...
>>>
>>
>> Yep, that looks better, thanks. It looks like your mail client screwed up the indenting and line wrapping in the patch. Can you try to re-send so it can be applied properly? One minor comment about the patch itself inline.
>>
> Hi Fabien,
>
> Did you get a chance to  make the minor tweak Lars suggested?

He did, but I just noticed he only sent it to me instead of the ml.