Re: [Qemu-devel] [PATCH v2 08/21] qcow2: More helpers for refcount modification

[Max Reitz <mreitz@redhat.com>]

On 2014-11-15 at 18:08, Eric Blake wrote:
> On 11/14/2014 06:06 AM, Max Reitz wrote:
>> Add helper functions for getting and setting refcounts in a refcount
>> array for any possible refcount order, and choose the correct one during
>> refcount initialization.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   block/qcow2-refcount.c | 146 ++++++++++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 144 insertions(+), 2 deletions(-)
>>
>> +static void get_refcount_functions(int refcount_order,
>> +                                   Qcow2GetRefcountFunc **get,
>> +                                   Qcow2SetRefcountFunc **set)
>> +{
>> +    switch (refcount_order) {
>> +        case 0:
>> +            *get = &get_refcount_ro0;
>> +            *set = &set_refcount_ro0;
>> +            break;
> Bike-shedding: instead of a switch statement and open-coded assignments,
> is it worth setting up an array of function pointers where you just grab
> the correct functions by doing array[refcount_order]?  But I don't see
> any strong reason to change style; what you have works.

I thought about it, but it wouldn't get much shorter. But maybe it looks 
nicer. I ought to think about it again.

Max

> Reviewed-by: Eric Blake <eblake@redhat.com>