From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v2][PATCH] kvm: x86: mmio: fix setting the present bit of mmio spte Date: Mon, 17 Nov 2014 12:40:52 +0100 Message-ID: <5469DEC4.6050206@redhat.com> References: <1416223883-4485-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Tiejun Chen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49288 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbaKQLk5 (ORCPT ); Mon, 17 Nov 2014 06:40:57 -0500 In-Reply-To: <1416223883-4485-1-git-send-email-tiejun.chen@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 17/11/2014 12:31, Tiejun Chen wrote: > In non-ept 64-bit of PAE case maxphyaddr may be 52bit as well, There is no such thing as 64-bit PAE. On 32-bit PAE hosts, PTEs have bit 62 reserved, as in your patch: > + /* Magic bits are always reserved for 32bit host. */ > + mask |= 0x3ull << 62; so there is no need to disable the MMIO page fault. Paolo