From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yerden Zhumabekov <e_zhumabekov-8EHiFRVJVgQ@public.gmane.org>
Subject: Re: [PATCH v2 3/4] hash: add fallback to software CRC32
 implementation
Date: Mon, 17 Nov 2014 18:41:51 +0600
Message-ID: <5469ED0F.5060709@sts.kz>
References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz>
 <1416160760-16087-4-git-send-email-e_zhumabekov@sts.kz>
 <2601191342CEEE43887BDE71AB977258213AE40F@IRSMSX105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: "Ananyev, Konstantin" <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "dev-VfR2kkLFssw@public.gmane.org"
 <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <2601191342CEEE43887BDE71AB977258213AE40F-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>


17.11.2014 18:34, Ananyev, Konstantin =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> Hi Yerden,
>
>> +static inline void
>> +rte_hash_crc_set_alg(enum crc32_alg_t alg)
>> +{
>> +	int sse42_supp =3D rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_2);
>> +	enum crc32_alg_t alg_supp =3D sse42_supp ? CRC32_SSE42 : CRC32_SW;
>> +
>> +	if (alg =3D=3D CRC32_SSE42)
>> +		crc32_alg =3D alg_supp;
>> +	else
>> +		crc32_alg =3D CRC32_SW;
>> +}
>> +
> Wonder can we define that function with __attribute__((constructor))?
> Then, I suppose we can remove CRC32_AUTODETECT, and remove:
> if (unlikely(crc32_alg =3D=3D CRC32_AUTODETECT))
>    rte_hash_crc_set_alg(CRC32_SSE42);  =20
> from rte_hash_crc_*byte().
Nice feature  I was unfamiliar with :)
Since I'm going to revise the patch series anyway, I'll apply it and
test. Thank you.

--=20
Sincerely,

Yerden Zhumabekov
State Technical Service
Astana, KZ