All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Julius Werner <jwerner@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>,
	Paul Zimmerman <paulz@synopsys.com>, Felipe Balbi <balbi@ti.com>,
	Dinh Nguyen <dinguyen@opensource.altera.com>,
	Romain Perier <romain.perier@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Sonny Rao <sonnyrao@chromium.org>,
	Addy Ke <addy.ke@rock-chips.com>, Eddie Cai <cf@rock-chips.com>,
	lyz <lyz@rock-chips.com>, wulf <wulf@rock-chips.com>,
	Tao Huang <huangtao@rock-chips.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2
Date: Mon, 17 Nov 2014 22:25:24 +0800	[thread overview]
Message-ID: <546A0554.1080809@rock-chips.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1411141038530.1043-100000@iolanthe.rowland.org>


On 11/14/2014 11:55 PM, Alan Stern wrote:
> On Thu, 13 Nov 2014, Julius Werner wrote:
>
>> Another thing might be that the port connect interrupt does not
>> correctly resume the root hub. I don't really know many details about
>> how that works, and it seems pretty complicated. But I can see that
>> all other HCDs seem to call usb_hcd_resume_root_hub() from their
>> interrupt handlers, which we don't. There's also a
> That's how a root hub sends a wakeup request to the kernel.  The
> controller issues an interrupt, and when the HCD's interrupt handler
> sees that the root hub is suspended, it calls usb_hcd_resume_root_hub()
> instead of trying to query the hardware (because in general you _can't_
> query the hardware while it's in a low-power state).
Thanks Alan and Julius, just like what you have mentioned, the dwc2 miss the
usb_hcd_resume_root_hub() when root hub is suspended and device connect
detected.

I have send another patch for that, hope it did the right thing.

- Kever


  reply	other threads:[~2014-11-17 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 13:09 [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2 Kever Yang
2014-11-12 23:22 ` Doug Anderson
2014-11-13  0:42   ` Kever Yang
2014-11-14  4:49     ` Julius Werner
2014-11-14 15:55       ` Alan Stern
2014-11-17 14:25         ` Kever Yang [this message]
2014-11-14 20:17       ` Paul Zimmerman
2015-01-06  1:23     ` Paul Zimmerman
2015-01-06  1:42       ` Kever Yang
2015-01-06  3:02         ` Paul Zimmerman
2015-01-07 17:14           ` Dinh Nguyen
2015-01-06  3:12       ` What are these weird line-noise signatures? Jeff Epler
2015-01-06  3:19         ` Peter Hurley
2015-01-06 13:15           ` Jeff Epler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546A0554.1080809@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=addy.ke@rock-chips.com \
    --cc=balbi@ti.com \
    --cc=cf@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=dinguyen@opensource.altera.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lyz@rock-chips.com \
    --cc=paulz@synopsys.com \
    --cc=romain.perier@gmail.com \
    --cc=sonnyrao@chromium.org \
    --cc=stern@rowland.harvard.edu \
    --cc=wulf@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.