From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqNLv-0004EZ-8x for qemu-devel@nongnu.org; Mon, 17 Nov 2014 09:32:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqNLp-0007mw-5O for qemu-devel@nongnu.org; Mon, 17 Nov 2014 09:32:27 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:59676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqNLo-0007mj-W9 for qemu-devel@nongnu.org; Mon, 17 Nov 2014 09:32:21 -0500 Message-ID: <546A06F2.5090408@imgtec.com> Date: Mon, 17 Nov 2014 14:32:18 +0000 From: Leon Alrae MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] mips: Correct the writes to CP0 Status and Cause registers via gdbstub List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" , qemu-devel@nongnu.org Cc: Aurelien Jarno Hi Maciej, On 10/11/2014 13:46, Maciej W. Rozycki wrote: > qemu-mips-status.diff > Index: qemu-git-trunk/target-mips/cpu.h > =================================================================== > --- qemu-git-trunk.orig/target-mips/cpu.h 2014-11-09 23:44:32.000000000 +0000 > +++ qemu-git-trunk/target-mips/cpu.h 2014-11-09 23:49:54.997846651 +0000 Could you please include diffstat when you generate patches? (git format-patch adds it by default). It makes review much easier - especially of longer patches - as it immediately tells which files and how many lines have been modified before starting looking at the actual changes. Thanks, Leon