From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XqOBk-0007GI-0B
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 10:26:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XqOBc-0002YE-CS
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 10:25:59 -0500
Received: from cantor2.suse.de ([195.135.220.15]:53600 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XqOBc-0002XV-0Y
	for qemu-devel@nongnu.org; Mon, 17 Nov 2014 10:25:52 -0500
Message-ID: <546A137E.2020202@suse.de>
Date: Mon, 17 Nov 2014 16:25:50 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1414861350-13099-1-git-send-email-marc.mari.barcelo@gmail.com>	<1414861350-13099-2-git-send-email-marc.mari.barcelo@gmail.com>	<20141117151621.GF16192@stefanha-thinkpad.redhat.com>
	<20141117161905.2dc3eee0@crunchbang>
In-Reply-To: <20141117161905.2dc3eee0@crunchbang>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to
 uint64_t in virtio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= <marc.mari.barcelo@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 17.11.2014 um 16:19 schrieb Marc Mar=C3=AD:
> El Mon, 17 Nov 2014 15:16:21 +0000
> Stefan Hajnoczi <stefanha@gmail.com> escribi=C3=B3:
>> On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Mar=C3=AD wrote:
>>> Convert use of pointers in functions of virtio to uint64_t in order
>>> to make it platform-independent.
>>>
>>> Add casting from pointers (in PCI functions) to uint64_t and vice
>>> versa through uintptr_t.
>>>
>>> Signed-off-by: Marc Mar=C3=AD <marc.mari.barcelo@gmail.com>
>>> ---
>>>  tests/libqos/virtio-pci.c |   20 +++++++++++---------
>>>  tests/libqos/virtio.c     |    8 ++++----
>>>  tests/libqos/virtio.h     |   16 ++++++++--------
>>>  tests/virtio-blk-test.c   |   21 ++++++++++++++-------
>>>  4 files changed, 37 insertions(+), 28 deletions(-)
>>
>> This makes sense.  To fully abolish pointers the PCI code also needs
>> to be converted.  Do plan plan to do that?
>>
>> Stefan
>=20
> Not planned, but if asked, I may do it.

Pretty please. :) I was wondering the same thing when reading the patch.

Regards,
Andreas

--=20
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 21284 AG N=C3=BC=
rnberg