From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ARM: dts: DRA7: Add node for RTC Date: Mon, 17 Nov 2014 19:12:14 +0300 Message-ID: <546A1E5E.1040909@cogentembedded.com> References: <1416199509-3977-1-git-send-email-lokeshvutla@ti.com> <5469E76A.7020105@cogentembedded.com> <5469F271.9080102@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f181.google.com ([209.85.217.181]:55755 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbaKQQMW (ORCPT ); Mon, 17 Nov 2014 11:12:22 -0500 Received: by mail-lb0-f181.google.com with SMTP id l4so16474504lbv.12 for ; Mon, 17 Nov 2014 08:12:16 -0800 (PST) In-Reply-To: <5469F271.9080102@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lokesh Vutla , linux-omap@vger.kernel.org Cc: Nishanth Menon , devicetree@vger.kernel.org, tony@atomide.com, nsekhar@ti.com, t-kristo@ti.com, linux-arm-kernel@lists.infradead.org On 11/17/2014 4:04 PM, Lokesh Vutla wrote: >> On 11/17/2014 7:45 AM, Lokesh Vutla wrote: >>> Add node for RTC. >>> Signed-off-by: Lokesh Vutla >>> [nm@ti.com: update with rtc crossbar number] >>> Signed-off-by: Nishanth Menon >>> --- >>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >>> index 9cc9843..f98f9f0 100644 >>> --- a/arch/arm/boot/dts/dra7.dtsi >>> +++ b/arch/arm/boot/dts/dra7.dtsi >>> @@ -1075,6 +1075,15 @@ >>> status = "disabled"; >>> }; >>> >>> + rtc: rtcss@48838000 { >> Please just name the node "rtc@48838000", in accordance with ePAPR. > Okay. will update it. >>> + compatible = "ti,am3352-rtc"; >>> + reg = <0x48838000 0x100>; >>> + interrupts = , >>> + ; >> 2 similar interrupts? > both rtc timer and rtc alarm uses same interrupt on DRA7 Soc. > Driver handles it accordingly. > So passing the same interrupt. I think it would have been better if the driver just handled a single interrupt. > Thanks and regards, > Lokesh >> [...] WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Mon, 17 Nov 2014 19:12:14 +0300 Subject: [PATCH] ARM: dts: DRA7: Add node for RTC In-Reply-To: <5469F271.9080102@ti.com> References: <1416199509-3977-1-git-send-email-lokeshvutla@ti.com> <5469E76A.7020105@cogentembedded.com> <5469F271.9080102@ti.com> Message-ID: <546A1E5E.1040909@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/17/2014 4:04 PM, Lokesh Vutla wrote: >> On 11/17/2014 7:45 AM, Lokesh Vutla wrote: >>> Add node for RTC. >>> Signed-off-by: Lokesh Vutla >>> [nm at ti.com: update with rtc crossbar number] >>> Signed-off-by: Nishanth Menon >>> --- >>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >>> index 9cc9843..f98f9f0 100644 >>> --- a/arch/arm/boot/dts/dra7.dtsi >>> +++ b/arch/arm/boot/dts/dra7.dtsi >>> @@ -1075,6 +1075,15 @@ >>> status = "disabled"; >>> }; >>> >>> + rtc: rtcss at 48838000 { >> Please just name the node "rtc at 48838000", in accordance with ePAPR. > Okay. will update it. >>> + compatible = "ti,am3352-rtc"; >>> + reg = <0x48838000 0x100>; >>> + interrupts = , >>> + ; >> 2 similar interrupts? > both rtc timer and rtc alarm uses same interrupt on DRA7 Soc. > Driver handles it accordingly. > So passing the same interrupt. I think it would have been better if the driver just handled a single interrupt. > Thanks and regards, > Lokesh >> [...] WBR, Sergei