All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: "xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [Xenomai] "inconsistent lock state" on boot-up
Date: Mon, 17 Nov 2014 17:48:00 +0100	[thread overview]
Message-ID: <546A26C0.1050309@siemens.com> (raw)
In-Reply-To: <20141112172738.GD17476@sisyphus.hd.free.fr>

On 2014-11-12 18:27, Gilles Chanteperdrix wrote:
> We do not need trace_hardirqs_on and trace_hardirqs_off for the
> particular case of IRQs: they are already handled by
> __ipipe_do_sync_stage. 

That was the key: Simply disabling the instrumentations in the
CONFIG_IPIPE removes all lock state inconsistencies, at least this far:

diff --git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
index d32f8bd..d8e0b2c 100644
--- a/arch/arm/kernel/entry-header.S
+++ b/arch/arm/kernel/entry-header.S
@@ -195,7 +195,7 @@
 #ifdef CONFIG_IPIPE_DEBUG_INTERNAL
 	bl	__ipipe_bugon_irqs_enabled
 #endif
-#ifdef CONFIG_TRACE_IRQFLAGS
+#if defined(CONFIG_TRACE_IRQFLAGS) && !defined(CONFIG_IPIPE)
 	@ The parent context IRQs must have been enabled to get here in
 	@ the first place, so there's no point checking the PSR I bit.
 	bl	trace_hardirqs_on
@@ -203,7 +203,7 @@
 	.else
 	@ IRQs off again before pulling preserved data off the stack
 	disable_irq_notrace
-#ifdef CONFIG_TRACE_IRQFLAGS
+#if defined(CONFIG_TRACE_IRQFLAGS) && !defined(CONFIG_IPIPE)
 	tst	\rpsr, #PSR_I_BIT
 	bleq	trace_hardirqs_on
 	tst	\rpsr, #PSR_I_BIT

Will send a patch.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux


  reply	other threads:[~2014-11-17 16:48 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-09 10:07 [Xenomai] "inconsistent lock state" on boot-up Stoidner, Christoph
2014-11-09 15:53 ` Gilles Chanteperdrix
2014-11-10  9:08   ` Stoidner, Christoph
2014-11-10 12:33     ` Stoidner, Christoph
2014-11-10 12:44       ` Gilles Chanteperdrix
2014-11-10 12:43     ` Gilles Chanteperdrix
2014-11-10 14:52       ` Jan Kiszka
2014-11-10 15:56         ` Gilles Chanteperdrix
2014-11-10 18:29           ` Jan Kiszka
2014-11-10 19:46             ` Gilles Chanteperdrix
2014-11-10 19:51               ` Gilles Chanteperdrix
2014-11-10 19:55               ` Jan Kiszka
2014-11-10 20:00                 ` Gilles Chanteperdrix
2014-11-10 20:02                   ` Jan Kiszka
2014-11-10 20:06                     ` Gilles Chanteperdrix
2014-11-10 20:10                       ` Jan Kiszka
2014-11-10 20:14                         ` Gilles Chanteperdrix
2014-11-10 20:17                           ` Jan Kiszka
2014-11-10 20:18                             ` Gilles Chanteperdrix
2014-11-10 20:22                               ` Jan Kiszka
2014-11-10 20:23                             ` Gilles Chanteperdrix
2014-11-10 20:28                               ` Jan Kiszka
2014-11-10 20:37                                 ` Gilles Chanteperdrix
2014-11-10 20:42                                   ` Jan Kiszka
2014-11-10 20:55                                     ` Gilles Chanteperdrix
2014-11-10 21:58                                       ` Gilles Chanteperdrix
2014-11-12 17:27                                         ` Gilles Chanteperdrix
2014-11-17 16:48                                           ` Jan Kiszka [this message]
2014-11-17 16:59                                             ` Gilles Chanteperdrix
2014-11-17 17:11                                               ` Jan Kiszka
2014-11-17 17:33                                                 ` Gilles Chanteperdrix
2014-11-17 19:07                                                   ` Jan Kiszka
2014-11-17 19:24                                                     ` Gilles Chanteperdrix
2014-11-18  6:19                                                       ` Jan Kiszka
2014-11-18  6:28                                                         ` Gilles Chanteperdrix
2014-11-11 17:33       ` Stoidner, Christoph
2014-11-11 17:46         ` Gilles Chanteperdrix
2014-11-11 18:04           ` Philippe Gerum
2014-11-17 10:01           ` Stoidner, Christoph
2014-11-17 10:22             ` Gilles Chanteperdrix
2014-11-17 11:13               ` Stoidner, Christoph
2014-11-17 11:30                 ` Philippe Gerum
2014-11-17 13:16                   ` Gilles Chanteperdrix
2014-11-17 11:49             ` Philippe Gerum
2014-11-17 11:51               ` Philippe Gerum
2014-11-17 13:10               ` Gilles Chanteperdrix
2014-11-17 13:33                 ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546A26C0.1050309@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=gilles.chanteperdrix@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.