From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2 Date: Mon, 17 Nov 2014 16:59:49 +0000 Message-ID: <546A2985.5000106@citrix.com> References: <1416237586-17785-1-git-send-email-andrew.cooper3@citrix.com> <1416243498.5466.27.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1416243498.5466.27.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , Boris Ostrovsky , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On 17/11/14 16:58, Ian Campbell wrote: > On Mon, 2014-11-17 at 15:19 +0000, Andrew Cooper wrote: >> c/s d1b93ea causes substantial functional regressions in pygrub's ability to >> parse bootloader configuration files. > Please can you and Boris both provide examples of (ideally real-world) > configuration files which exhibit these failures as patches against > tools/pygrub/examples/. > > Boris, in your case I mean the one which caused you to write the > original patch, which I should have remembered to ask for at the time. > > Andy, in your case it would make sense to include at least one in this > patch I think. > > Ian. > examples/ doesn't help. The parsers themselves don't exhibit the bug. It is only when pygrub itself attempts to interact with the parsed config does the issue exhibits itself. I would have provided an example if it would have helped. ~Andrew