From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH for-4.5 RFC] pygrub: Fix regression from c/s
 d1b93ea, attempt 2
Date: Mon, 17 Nov 2014 12:15:08 -0500
Message-ID: <546A2D1C.7040409@oracle.com>
References: <1416237586-17785-1-git-send-email-andrew.cooper3@citrix.com>
	<1416243498.5466.27.camel@citrix.com> <546A2985.5000106@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <546A2985.5000106@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/17/2014 11:59 AM, Andrew Cooper wrote:
> On 17/11/14 16:58, Ian Campbell wrote:
>> On Mon, 2014-11-17 at 15:19 +0000, Andrew Cooper wrote:
>>> c/s d1b93ea causes substantial functional regressions in pygrub's ability to
>>> parse bootloader configuration files.
>> Please can you and Boris both provide examples of (ideally real-world)
>> configuration files which exhibit these failures as patches against
>> tools/pygrub/examples/.
>>
>> Boris, in your case I mean the one which caused you to write the
>> original patch, which I should have remembered to ask for at the time.


I wanted to be able to parse grub2's default values set as strings, such as

    set default="Fedora, with Xen xen and Linux 3.17.0-rc3"

or, for submenus

    set default="Advanced options for Fedora (with Xen 
hypervisor)>Fedora, with Xen xen and Linux 3.17.0-rc3"

Original pygrub would not be able to understand the string and default 
to zero.

-boris


>>
>> Andy, in your case it would make sense to include at least one in this
>> patch I think.
>>
>> Ian.
>>
> examples/ doesn't help.  The parsers themselves don't exhibit the bug.
> It is only when pygrub itself attempts to interact with the parsed
> config does the issue exhibits itself.
>
> I would have provided an example if it would have helped.
>
> ~Andrew