From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 33658E008B4; Mon, 17 Nov 2014 10:46:39 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.42 listed in list.dnswl.org] Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id A35BFE00872 for ; Mon, 17 Nov 2014 10:46:31 -0800 (PST) Received: by mail-wg0-f42.google.com with SMTP id z12so7553432wgg.15 for ; Mon, 17 Nov 2014 10:46:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=6gCHyNHSYuqWFzHNWqd8YCi5+hJotJ/n2G9aiBdxAoo=; b=ORLsjfchfe1n0lbX9v36ssrZiA8kSTq13AraXOm1ULgUOxcv7nwHZvljEbGKbDr2Lp tYkprbrRV8xaUi76GXwAWx+N1jcvuQo9tEo1golKRn3cWIE9cXYq4pD863TJScI9KdF2 89MK27gl5WlZeXFFxb3uUBO9A5NpI9vpWlK4MOx9q/hHy6y0tX93MjJZxs312cy9uLYO 4FYkB+HU7mtrw0Kz/jVeONPCQkvkoDk/SxcdoLXzZh9rH2brCJC7scexDQWhnWtxMXxC 8gXP3rebPuKiGChzLUcSoFUN7mT95Tfqd0PjsYcr3CIMaZ4+m4uWF3vkRwYOSGXqSgbD aj+w== X-Gm-Message-State: ALoCoQlVM3vuEVbD/PiBiqyPdGtdGoWNBTN95it6lsxQj+1+WusLgQ4UKF3GQTG8UTuUN37uTJr5 X-Received: by 10.194.248.162 with SMTP id yn2mr41116693wjc.16.1416249990451; Mon, 17 Nov 2014 10:46:30 -0800 (PST) Received: from [192.168.2.65] ([83.217.123.106]) by mx.google.com with ESMTPSA id hs1sm3619297wib.1.2014.11.17.10.46.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Nov 2014 10:46:29 -0800 (PST) Message-ID: <546A4285.8020805@intel.com> Date: Mon, 17 Nov 2014 18:46:29 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: In-Reply-To: Subject: Re: [review-request] bbarrosp/all-pages X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2014 18:46:39 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 13/11/14 11:40, Barros Pena, Belen wrote: > This branch: > > * Fixes the layout of the dependencies modal dialog > * Removes the external link icon from the target name column when the cell > is empty > * Adds the 'no results' state to the all layers page > > Thanks! > > Belén > commit e8107bbb44afeec888667f5239afa33bf71235b4 {{o.name}} - + {% if o.name %} + + {% endif%} A tiny tiny niggle would be that {{o.name}} could be inside the if statement so that when you read it, it's not "use this var... now check it exists" the templating engine will do the right thing so it's just a reading issue. commit 8c38eec9e48e2bcf492584f70991056a3513c479 IMO we should avoid using 'Named access on the Window object' as they're a bit dodgy/too magic[1]. But as you know other templates in toaster already have this same code, so we may as commit it and fix it with a next refactoring commit. other than that looks good to me. Michael [1] good article about that here http://tjvantoll.com/2012/07/19/dom-element-references-as-global-variables/