From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?SmFudXN6IFXFvHlja2k=?= Subject: Re: [PATCH] gpio: mxs: implement get_direction callback Date: Mon, 17 Nov 2014 20:02:54 +0100 Message-ID: <546A465E.5080904@elproma.com.pl> References: <1416004026-9667-1-git-send-email-j.uzycki@elproma.com.pl> <20141114232601.GW27002@pengutronix.de> <5467A980.5090204@elproma.com.pl> <20141116214239.GX27002@pengutronix.de> <54693A51.5080907@elproma.com.pl> <54695654.3070209@elproma.com.pl> <20141117082848.GZ27002@pengutronix.de> <546A29B9.5030104@elproma.com.pl> <546A2B69.4010409@elproma.com.pl> <20141117184229.GM27002@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141117184229.GM27002@pengutronix.de> Sender: linux-serial-owner@vger.kernel.org To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= Cc: Richard Genoud , Linus Walleij , Alexandre Courbot , fabio.estevam@freescale.com, Greg Kroah-Hartman , linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org Hello Uwe, W dniu 2014-11-17 o 19:42, Uwe Kleine-K=C3=B6nig pisze: > Hello Janusz, > > On Mon, Nov 17, 2014 at 06:07:53PM +0100, Janusz U=C5=BCycki wrote: >>> It looks there could be one more helper useful. >>> Both atmel_serial.c and mxs-auart.c checks if the line is >>> supported by mctrl_gpio. >>> One time it is eg.: >>> (s->gpio_irq[UART_GPIO_DCD] > 0) >>> another time it is eg.: >>> IS_ERR_OR_NULL(mctrl_gpio_to_gpiod(s->gpios, UART_GPIO_RTS)) >>> >>> The first one is no possible now. The second seems rude. >>> bool mctrl_gpio_is_gpio((struct mctrl_gpios *gpios, enum >>> mctrl_gpio_idx gidx); >>> The name is hard. Moreover the implementation could be very similar >>> to mctrl_gpio_to_gpiod(). Any ideas? >> The differences: >> - faster >> - not exported >> - used mainly in uart's interrupt >> - assumes that struct mctrl_gpios *gpios exists > I wonder why you need it at all?! If the line is not supported by gpio it could be supported by native=20 uart's hardware if possible. There are different configurations. One port has the lines= ,=20 other which uses the same driver doesn't have. Let's look at disable/enable_ms() in atmet_serial.c. In mxs-auart DMA is not used if CTS or RTS is gpio line (timming). best regards Janusz > > Best regards > Uwe > -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: j.uzycki@elproma.com.pl (=?UTF-8?B?SmFudXN6IFXFvHlja2k=?=) Date: Mon, 17 Nov 2014 20:02:54 +0100 Subject: [PATCH] gpio: mxs: implement get_direction callback In-Reply-To: <20141117184229.GM27002@pengutronix.de> References: <1416004026-9667-1-git-send-email-j.uzycki@elproma.com.pl> <20141114232601.GW27002@pengutronix.de> <5467A980.5090204@elproma.com.pl> <20141116214239.GX27002@pengutronix.de> <54693A51.5080907@elproma.com.pl> <54695654.3070209@elproma.com.pl> <20141117082848.GZ27002@pengutronix.de> <546A29B9.5030104@elproma.com.pl> <546A2B69.4010409@elproma.com.pl> <20141117184229.GM27002@pengutronix.de> Message-ID: <546A465E.5080904@elproma.com.pl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Uwe, W dniu 2014-11-17 o 19:42, Uwe Kleine-K?nig pisze: > Hello Janusz, > > On Mon, Nov 17, 2014 at 06:07:53PM +0100, Janusz U?ycki wrote: >>> It looks there could be one more helper useful. >>> Both atmel_serial.c and mxs-auart.c checks if the line is >>> supported by mctrl_gpio. >>> One time it is eg.: >>> (s->gpio_irq[UART_GPIO_DCD] > 0) >>> another time it is eg.: >>> IS_ERR_OR_NULL(mctrl_gpio_to_gpiod(s->gpios, UART_GPIO_RTS)) >>> >>> The first one is no possible now. The second seems rude. >>> bool mctrl_gpio_is_gpio((struct mctrl_gpios *gpios, enum >>> mctrl_gpio_idx gidx); >>> The name is hard. Moreover the implementation could be very similar >>> to mctrl_gpio_to_gpiod(). Any ideas? >> The differences: >> - faster >> - not exported >> - used mainly in uart's interrupt >> - assumes that struct mctrl_gpios *gpios exists > I wonder why you need it at all?! If the line is not supported by gpio it could be supported by native uart's hardware if possible. There are different configurations. One port has the lines, other which uses the same driver doesn't have. Let's look at disable/enable_ms() in atmet_serial.c. In mxs-auart DMA is not used if CTS or RTS is gpio line (timming). best regards Janusz > > Best regards > Uwe >