From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v9 2/9] qcom: spm: Add Subsystem Power Manager driver Date: Mon, 17 Nov 2014 22:32:18 +0100 Message-ID: <546A6962.9090801@linaro.org> References: <1414194024-55547-1-git-send-email-lina.iyer@linaro.org> <1414194024-55547-3-git-send-email-lina.iyer@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f50.google.com ([74.125.82.50]:38343 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbaKQVcV (ORCPT ); Mon, 17 Nov 2014 16:32:21 -0500 Received: by mail-wg0-f50.google.com with SMTP id k14so7930248wgh.9 for ; Mon, 17 Nov 2014 13:32:20 -0800 (PST) In-Reply-To: <1414194024-55547-3-git-send-email-lina.iyer@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lina Iyer , khilman@linaro.org, sboyd@codeaurora.org, galak@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: lorenzo.pieralisi@arm.com, msivasub@codeaurora.org, devicetree@vger.kernel.org On 10/25/2014 01:40 AM, Lina Iyer wrote: Hi Lina, [ ... ] > +static inline void spm_register_write(struct spm_driver_data *drv, > + enum spm_reg reg, u32 val) > +{ > + if (drv->reg_data->reg_offset[reg]) > + writel_relaxed(val, drv->reg_base + > + drv->reg_data->reg_offset[reg]); Why not use writel and don't use 'wmb' below ? > +} > + [ ... ] > + spm_register_write(drv, SPM_REG_SPM_CTL, ctl_val); > + > + /* Ensure we have written the start address */ > + wmb(); --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Mon, 17 Nov 2014 22:32:18 +0100 Subject: [PATCH v9 2/9] qcom: spm: Add Subsystem Power Manager driver In-Reply-To: <1414194024-55547-3-git-send-email-lina.iyer@linaro.org> References: <1414194024-55547-1-git-send-email-lina.iyer@linaro.org> <1414194024-55547-3-git-send-email-lina.iyer@linaro.org> Message-ID: <546A6962.9090801@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/25/2014 01:40 AM, Lina Iyer wrote: Hi Lina, [ ... ] > +static inline void spm_register_write(struct spm_driver_data *drv, > + enum spm_reg reg, u32 val) > +{ > + if (drv->reg_data->reg_offset[reg]) > + writel_relaxed(val, drv->reg_base + > + drv->reg_data->reg_offset[reg]); Why not use writel and don't use 'wmb' below ? > +} > + [ ... ] > + spm_register_write(drv, SPM_REG_SPM_CTL, ctl_val); > + > + /* Ensure we have written the start address */ > + wmb(); -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog