From: Andy Grover <agrover@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
nab@linux-iscsi.org
Subject: Re: [PATCH 3/3] target: Change some fabric functions to return bool
Date: Mon, 17 Nov 2014 14:58:06 -0800 [thread overview]
Message-ID: <546A7D7E.7090808@redhat.com> (raw)
In-Reply-To: <20141114070604.GB3944@lst.de>
On 11/13/2014 11:06 PM, Christoph Hellwig wrote:
> On Thu, Nov 13, 2014 at 12:50:58PM -0800, Andy Grover wrote:
>> The tpg_check_* functions in the fabric_ops struct return 1 or 0,
>> so we can make their return type bool. Change fabrics to match.
>
> All these true/false stub sounds like some of them methods should be
> optional, and a useful default should be assumed if they aren't present.
This may be true but I couldn't determine a useful default, or a change
that would make the code shorter or clearer, so I left it for now.
-- Andy
prev parent reply other threads:[~2014-11-17 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 20:50 [PATCH 1/3] target: Remove TRANSPORT_LUNFLAGS_READ_WRITE Andy Grover
2014-11-13 20:50 ` [PATCH 2/3] target: Remove TRANSPORT_LUNFLAGS_NO_ACCESS Andy Grover
2014-11-13 20:50 ` [PATCH 3/3] target: Change some fabric functions to return bool Andy Grover
2014-11-14 7:06 ` Christoph Hellwig
2014-11-17 22:58 ` Andy Grover [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A7D7E.7090808@redhat.com \
--to=agrover@redhat.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.