From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 97950E008DC; Tue, 18 Nov 2014 00:54:28 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [157.55.234.71 listed in list.dnswl.org] * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0071.outbound.protection.outlook.com [157.55.234.71]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id ECCF7E008D4 for ; Tue, 18 Nov 2014 00:54:10 -0800 (PST) Received: from [192.168.1.168] (93.64.190.105) by AM3PR04MB388.eurprd04.prod.outlook.com (10.242.112.154) with Microsoft SMTP Server (TLS) id 15.1.16.15; Tue, 18 Nov 2014 08:54:06 +0000 Message-ID: <546B092C.1050101@giuneco.it> Date: Tue, 18 Nov 2014 09:54:04 +0100 From: Gianluca Cinci User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Daiane Angolini References: <5462A702.3040909@giuneco.it> <54646A34.6080201@giuneco.it> In-Reply-To: X-Originating-IP: [93.64.190.105] X-ClientProxiedBy: AMSPR02CA0012.eurprd02.prod.outlook.com (10.242.225.140) To AM3PR04MB388.eurprd04.prod.outlook.com (10.242.112.154) X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB388; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB388; X-Forefront-PRVS: 039975700A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(164054003)(51704005)(24454002)(199003)(5423002)(189002)(377454003)(479174003)(105586002)(92566001)(107046002)(106356001)(50986999)(575784001)(86362001)(110136001)(59896002)(230783001)(95666004)(92726001)(65806001)(87266999)(65816999)(20776003)(87976001)(47776003)(21056001)(66066001)(76176999)(65956001)(54356999)(15202345003)(64706001)(50466002)(122386002)(36756003)(64126003)(83506001)(15975445006)(19580405001)(42186005)(33656002)(102836001)(4396001)(80316001)(23676002)(93886004)(19580395003)(117156001)(99396003)(77156002)(40100003)(97736003)(46102003)(31966008)(120916001)(77096003)(74482002)(101416001)(62966003)(3076001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR04MB388; H:[192.168.1.168]; FPR:; MLV:sfv; PTR:InfoNoRecords; A:1; MX:1; LANG:en; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB388; X-OriginatorOrg: giuneco.it Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 08:54:28 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Hi Daiane, On 13/11/2014 11:28, Daiane Angolini wrote: > On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci > wrote: >> Hi Daiane, >> sure , the patch is attached to this mail (let me know if I must to change >> it) > Thanks, when send a patch to meta-freescale, please use git send email > (I think you did this the first time, right? yes , I hope the patch is properly formatted... Best Regards Gianluca > > I copied your patch at the end of this reply, because I have some comments. > > I cannot comment properly on the gpu code itself, so I would expect > someone else to also comment on the patch. > > >> About the cinematicexperience + eglfs dependecies: >> With the only inclusion of cinematicexperience the "EGL..." error come out >> , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary >> library on my fs. > > Oh, and please, do not top-post. > >> Bests Regards >> Gianluca >> > your patch: > (I added 2 comments inline) > > > From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 2001 > From: gianluca > Date: Thu, 13 Nov 2014 00:11:51 +0100 > Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free issue on > application exit > > [Daiane] > For this subject please use something like: > > [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid > shared memory free issue. > > use as example: > http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-kernel/linux/linux-imx_2.6.35.3.bb > > > Signed-off-by: gianluca > --- > .../avoid-shared-memory-free-issue.patch | 26 ++++++++++++++++++++++ > recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + > 2 files changed, 27 insertions(+) > create mode 100644 > recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > > diff --git a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > new file mode 100644 > index 0000000..a109cc0 > --- /dev/null > +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > @@ -0,0 +1,26 @@ > +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 > +From: gianluca > +Date: Tue, 11 Nov 2014 22:25:17 +0100 > +Subject: [PATCH] avoid shared memory free issue on application exit > > [Daiane] > > For this subject use: > [PATCH] imx: amd-gpu: avoid shared memory free issue on application > > and add the tag Upstream-Status, use as example > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations > > > + > +--- > + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ > + 1 file changed, 3 insertions(+) > + > +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +index 51e66f9..2529267 100644 > +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, > unsigned int pid) > + } > + else > + { > ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the > previously allocated memory if > ++ // gpuaddress is present in gsl_linux_map_list > ++ > + status = GSL_FAILURE; > + } > + > +-- > +1.9.1 > + > diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb > b/recipes-kernel/linux/linux-imx_2.6.35.3.bb > index bfc56b7..ad1f10b 100644 > --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb > +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb > @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" > SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ > file://perf-avoid-use-sysroot-headers.patch \ > + file://avoid-shared-memory-free-issue.patch \ > " > > > SRC_URI_append_mx28 = " \