From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] nbd: Use BlockBackend internally
Date: Tue, 18 Nov 2014 10:32:33 +0100 [thread overview]
Message-ID: <546B1231.90406@redhat.com> (raw)
In-Reply-To: <546A305E.9040709@redhat.com>
On 2014-11-17 at 18:29, Paolo Bonzini wrote:
>
> On 17/11/2014 16:30, Max Reitz wrote:
>> With all externally visible functions changed to use BlockBackend, this
>> patch makes nbd use BlockBackend for everything internally as well.
>>
>> While touching them, substitute 512 by BDRV_SECTOR_SIZE in the calls to
>> blk_read(), blk_write() and blk_co_discard().
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> qemu-nbd.c has more uses of "bs" that probably should be changed to
> "blk". Not sure if it should be in this patch, patch 4 or an additional
> patch 6 though.
Good point. I'll go for patch 6.
> If the third possibility, series
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks!
Max
prev parent reply other threads:[~2014-11-18 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:30 [Qemu-devel] [PATCH 0/5] nbd: Use BlockBackend Max Reitz
2014-11-17 15:30 ` [Qemu-devel] [PATCH 1/5] block: Lift more functions into BlockBackend Max Reitz
2014-11-17 15:30 ` [Qemu-devel] [PATCH 2/5] block: Add AioContextNotifier functions to BB Max Reitz
2014-11-17 17:26 ` Paolo Bonzini
2014-11-18 9:26 ` Max Reitz
2014-11-18 9:44 ` Paolo Bonzini
2014-11-17 15:30 ` [Qemu-devel] [PATCH 3/5] block: Add blk_add_close_notifier() for BB Max Reitz
2014-11-17 15:30 ` [Qemu-devel] [PATCH 4/5] nbd: Change external interface to BlockBackend Max Reitz
2014-11-17 15:30 ` [Qemu-devel] [PATCH 5/5] nbd: Use BlockBackend internally Max Reitz
2014-11-17 17:29 ` Paolo Bonzini
2014-11-18 9:32 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546B1231.90406@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.