From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH v1 1/2] efuse: IMG Pistachio eFuse Controller Date: Tue, 18 Nov 2014 09:45:17 +0000 Message-ID: <546B152D.1010804@imgtec.com> References: <1416237576-21542-1-git-send-email-arul.ramasamy@imgtec.com> <1416237576-21542-2-git-send-email-arul.ramasamy@imgtec.com> <546A189B.3090202@imgtec.com> <27E62D98F903554192E3C13AFCC91C3C2F506FE2@hbmail01.hb.imgtec.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="THNPLOi4jCv6bgm7IIX7S9UkSsfVKJVNQ" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Bresticker , Naidu Tellapati Cc: Arul Ramasamy , "arnd-r2nGTMty4D4@public.gmane.org" , "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" , "treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org" , "swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org" , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , James Hartley , Ezequiel Garcia , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jude Abraham List-Id: devicetree@vger.kernel.org --THNPLOi4jCv6bgm7IIX7S9UkSsfVKJVNQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 18/11/14 00:26, Andrew Bresticker wrote: > Hi Naidu, >=20 > On Mon, Nov 17, 2014 at 4:12 PM, Naidu Tellapati > wrote: >> Hi Andrew, >> >> (We will respond to James Hogan's remaining review comments in a separ= ate email) >> >>>> >>>> +obj-$(CONFIG_SOC_IMG) +=3D pistachio/ >> >>> What is CONFIG_SOC_IMG? It sounds very generic. >> >> May I have your suggestions on the above. >> >> (Assuming we create drivers/soc/img/ instead of drivers/soc/pistachio/= ) What would "belong" in there? Basically anything that doesn't belong in some particular subsystem? > I don't have much visibility into ImgTec SoCs other than Pistachio, > but I think introducing a SOC_IMG Kconfig symbol is a good idea as it > gives drivers for various pieces of IP present on ImgTec SoCs > (watchdog, I2C, DMA, etc.) a more specific dependency than say MIPS or > METAG. Maybe James has a suggestion for how to deal with this? I have very limited experience with IMG based SoCs other than Chorus2 and TZ1090, but I'm not convinced an SOC_IMG adds any value tbh if it is simply a way to group drivers. Both SOC_IMG and METAG || MIPS would end up being fuzzy/inexact convenience dependencies to reduce clutter on other platforms, so perhaps it would be best kept simple, flexible and easily understandable. I don't feel strongly about it either way though. I suspect certain IP blocks may potentially get licensed separately and require exceptions (PDP springs to mind?), so it probably is technically a per-IP block thing. James Hartley might have a better idea about that. Cheers James --THNPLOi4jCv6bgm7IIX7S9UkSsfVKJVNQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUaxU1AAoJEGwLaZPeOHZ63w0P/iZz4oOwcFQ/Si0djuYigPKm KMTgjEiasD7ElkF1LHhEOobJyoHSkzxo/9YlUjb+l9i727yMlxfOfcnfpGjDsaZ5 HnFUlHuGEYeUewLsDJnFhzwuH3hvJ6FZqJjFLl8yxDdUlIsUlyxYq3iPK0VRUaoH LPvijAm1meZ8sQQbrG48qqQDBBmdtx2j4TIgS3EWuy1GLFZMRlwuF22+aL5YdoFW errzLa2L67LoBYNW/gIGzVNWfd+58EPn2bX+dg1V4Mt+2cq6hyGybD7ZQmDPYNGl XZPNMLxl1KdXXi7aCBQuwFxVKjTJDUwF1yI3sFyh4Prc6MpQwQWROkuDoAcl+sgD KS9838pDqAE8VPb1bETUfel2gQJ8oJCzIQcrBfWFkiZC6Wo/Apd2AxZfuIHttzSP qcZNZj6nNcTp8NkJ7li9H6OogLWmyvcBVqn4GIQShpcUhJv4OfvPfKoQwhnI0W9m +UqiCwoGNdYz1n8nM2dMHrjlQUGPTWNrFC0MmBjq/wEw1a3Yg3OBZTf3OMysZgZU ZcdAfsnYX9LZoUZ1yDxU7KYqXBGAtazrh5mp5hcPmqEF52Lqi4V38ZTQWzkLX/oh 6ZAm4VczG92DYBam1r7lIaCmmj8CVU4/B36fT5h27Rg1q2pQqOY28ryb3H3xIC+H ZhPmTCVlJC54sv+1k+rQ =NiWm -----END PGP SIGNATURE----- --THNPLOi4jCv6bgm7IIX7S9UkSsfVKJVNQ-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html