From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm: x86: vmx: cleanup handle_ept_violation Date: Tue, 18 Nov 2014 11:08:29 +0100 Message-ID: <546B1A9D.8050705@redhat.com> References: <1416301976-6187-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Tiejun Chen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752715AbaKRKIe (ORCPT ); Tue, 18 Nov 2014 05:08:34 -0500 In-Reply-To: <1416301976-6187-1-git-send-email-tiejun.chen@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 18/11/2014 10:12, Tiejun Chen wrote: > Instead, just use PFERR_{FETCH, PRESENT, WRITE}_MASK > inside handle_ept_violation() for slightly better code. > > Signed-off-by: Tiejun Chen > --- > arch/x86/kvm/vmx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 284f5c2..22dc60d 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -5474,11 +5474,11 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu) > trace_kvm_page_fault(gpa, exit_qualification); > > /* It is a write fault? */ > - error_code = exit_qualification & (1U << 1); > + error_code = exit_qualification & PFERR_WRITE_MASK; > /* It is a fetch fault? */ > - error_code |= (exit_qualification & (1U << 2)) << 2; > + error_code |= (exit_qualification << 2) & PFERR_FETCH_MASK; > /* ept page table is present? */ > - error_code |= (exit_qualification >> 3) & 0x1; > + error_code |= (exit_qualification >> 3) & PFERR_PRESENT_MASK; Ok. Paolo