All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] sun6i: Drop some "unknown magic" from dram init
Date: Tue, 18 Nov 2014 13:47:59 +0100	[thread overview]
Message-ID: <546B3FFF.2080202@redhat.com> (raw)
In-Reply-To: <1416250917.25454.33.camel@hellion.org.uk>

Hi,

On 11/17/2014 08:01 PM, Ian Campbell wrote:
> On Sun, 2014-11-16 at 17:16 +0100, Hans de Goede wrote:
>> This bit of code is the rtc ram being used to detect coming out of
>> "super-standby" mode, and if that is the case, going out of self-refresh mode.
>>
>> Since we do not support "super-standby" mode, this can be dropped.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
> 
> (perhaps start the commit log with "Allwinner tells us that..."? Ack
> either way)

Fixed in my local tree.

Regards,

Hans

> 
>> ---
>>  arch/arm/cpu/armv7/sunxi/dram_sun6i.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun6i.c b/arch/arm/cpu/armv7/sunxi/dram_sun6i.c
>> index 2ac0b58..5e163cb 100644
>> --- a/arch/arm/cpu/armv7/sunxi/dram_sun6i.c
>> +++ b/arch/arm/cpu/armv7/sunxi/dram_sun6i.c
>> @@ -140,9 +140,6 @@ static void mctl_channel_init(int ch_index, struct dram_sun6i_para *para)
>>  
>>  	writel((MCTL_TITMSRST << 18) | (MCTL_TDLLLOCK << 6) | MCTL_TDLLSRST,
>>  	       &mctl_phy->ptr0);
>> -	/* Unknown magic performed by boot0 */
>> -	if ((readl(SUNXI_RTC_BASE + 0x20c) & 3) == 2)
>> -		setbits_le32(&mctl_phy->ptr0, 1 << 18);
>>  
>>  	writel((MCTL_TDINIT1 << 19) | MCTL_TDINIT0, &mctl_phy->ptr1);
>>  	writel((MCTL_TDINIT3 << 17) | MCTL_TDINIT2, &mctl_phy->ptr2);
> 
> 

  reply	other threads:[~2014-11-18 12:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16 16:16 [U-Boot] [PATCH 1/5] sun6i: Make dram clk and zq value Kconfig options Hans de Goede
2014-11-16 16:16 ` [U-Boot] [PATCH 2/5] sun6i: Add sunxi_get_ss_bonding_id() function Hans de Goede
2014-11-17 18:57   ` Ian Campbell
2014-11-16 16:16 ` [U-Boot] [PATCH 3/5] sun6i: dram: Do not try to initialize a second dram chan on A31s Hans de Goede
2014-11-17 19:00   ` Ian Campbell
2014-11-18 12:34     ` Hans de Goede
2014-11-18 14:08       ` Ian Campbell
2014-11-16 16:16 ` [U-Boot] [PATCH 4/5] sun6i: Drop some "unknown magic" from dram init Hans de Goede
2014-11-17 19:01   ` Ian Campbell
2014-11-18 12:47     ` Hans de Goede [this message]
2014-11-16 16:16 ` [U-Boot] [PATCH 5/5] sun6i: Add new CSQ_CS908 board Hans de Goede
2014-11-17 19:03   ` Ian Campbell
2014-11-18 12:47     ` Hans de Goede
2014-11-18 14:10       ` Ian Campbell
2014-11-19 13:41         ` Hans de Goede
2014-11-17 18:54 ` [U-Boot] [PATCH 1/5] sun6i: Make dram clk and zq value Kconfig options Ian Campbell
2014-11-18 11:32   ` Hans de Goede
2014-11-18 14:07     ` Ian Campbell
2014-11-19 13:39       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546B3FFF.2080202@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.