From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yerden Zhumabekov Subject: Re: [PATCH v3 3/5] hash: add fallback to software CRC32 implementation Date: Tue, 18 Nov 2014 19:37:07 +0600 Message-ID: <546B4B83.4070103@sts.kz> References: <1416160760-16087-1-git-send-email-e_zhumabekov@sts.kz> <546AD178.9070109@sts.kz> <20141118133307.GA32375@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: Neil Horman , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <20141118133307.GA32375-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 18.11.2014 19:33, Neil Horman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Tue, Nov 18, 2014 at 10:56:24AM +0600, Yerden Zhumabekov wrote: >> Sorry, maybe I made a mistake here. >> >> Accoring to lib/librte_eal/common/eal_common_cpuflags.c code, it seeme= d >> to me that constructor attribute is not supported by intel compiler. S= o >> in that case here I decided to leave the code for autodetection. Am I >> correct? >> > I don't think thats correct. The Intel Compiler claims support for most= GCC > features, except where explicitly stated in the release notes, and I do= n't find > any documentation clearly excepting the constructor attribute from that= list. > That said, since the intel compiler isn't open, I don't have access to = it and > cannot confirm either way, though if its the case, the DPDK has a major= issue, > as __attribute__((constructor)) is used extensively throughout the code > Neil My bad. Ok, I'll redo it again and send the series as 'v4'. Thanks. --=20 Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ