From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v5 01/18] ARM64: Move the init of cpu_logical_map(0) before unflatten_device_tree() Date: Tue, 18 Nov 2014 21:45:49 +0800 Message-ID: <546B4D8D.2020605@linaro.org> References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-2-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pd0-f178.google.com ([209.85.192.178]:32891 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300AbaKRNqA (ORCPT ); Tue, 18 Nov 2014 08:46:00 -0500 Received: by mail-pd0-f178.google.com with SMTP id y13so8220404pdi.23 for ; Tue, 18 Nov 2014 05:46:00 -0800 (PST) In-Reply-To: <1413553034-20956-2-git-send-email-hanjun.guo@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Catalin Marinas , Will Deacon Cc: "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , Grant Likely , Graeme Gregory , Arnd Bergmann , Sudeep Holla , Jon Masters , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles.Garcia-Tobin@arm.com, Kangkang.Shen@huawei.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger Hi Catalin, On 2014=E5=B9=B410=E6=9C=8817=E6=97=A5 21:36, Hanjun Guo wrote: > It always make sense to initialize CPU0's logical map entry from the > hardware values, so move the initialization of cpu_logical_map(0) > before unflatten_device_tree() which is needed by ACPI code later. > > Acked-by: Olof Johansson > Acked-by: Mark Rutland > Signed-off-by: Hanjun Guo Could you merge this patch first in 3.19? It was acked by Olof and Mark, and it will make sense without ACPI too. Thanks Hanjun > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index edb146d..8f33f72 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -393,11 +393,11 @@ void __init setup_arch(char **cmdline_p) > > efi_idmap_init(); > > + cpu_logical_map(0) =3D read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > unflatten_device_tree(); > > psci_init(); > > - cpu_logical_map(0) =3D read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > cpu_read_bootcpu_ops(); > #ifdef CONFIG_SMP > smp_init_cpus(); > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Tue, 18 Nov 2014 21:45:49 +0800 Subject: [PATCH v5 01/18] ARM64: Move the init of cpu_logical_map(0) before unflatten_device_tree() In-Reply-To: <1413553034-20956-2-git-send-email-hanjun.guo@linaro.org> References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-2-git-send-email-hanjun.guo@linaro.org> Message-ID: <546B4D8D.2020605@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Catalin, On 2014?10?17? 21:36, Hanjun Guo wrote: > It always make sense to initialize CPU0's logical map entry from the > hardware values, so move the initialization of cpu_logical_map(0) > before unflatten_device_tree() which is needed by ACPI code later. > > Acked-by: Olof Johansson > Acked-by: Mark Rutland > Signed-off-by: Hanjun Guo Could you merge this patch first in 3.19? It was acked by Olof and Mark, and it will make sense without ACPI too. Thanks Hanjun > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index edb146d..8f33f72 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -393,11 +393,11 @@ void __init setup_arch(char **cmdline_p) > > efi_idmap_init(); > > + cpu_logical_map(0) = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > unflatten_device_tree(); > > psci_init(); > > - cpu_logical_map(0) = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > cpu_read_bootcpu_ops(); > #ifdef CONFIG_SMP > smp_init_cpus(); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010AbaKRNqD (ORCPT ); Tue, 18 Nov 2014 08:46:03 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:57079 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbaKRNqA (ORCPT ); Tue, 18 Nov 2014 08:46:00 -0500 Message-ID: <546B4D8D.2020605@linaro.org> Date: Tue, 18 Nov 2014 21:45:49 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Catalin Marinas , Will Deacon CC: "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , Grant Likely , Graeme Gregory , Arnd Bergmann , Sudeep Holla , Jon Masters , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles.Garcia-Tobin@arm.com, Kangkang.Shen@huawei.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org Subject: Re: [PATCH v5 01/18] ARM64: Move the init of cpu_logical_map(0) before unflatten_device_tree() References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-2-git-send-email-hanjun.guo@linaro.org> In-Reply-To: <1413553034-20956-2-git-send-email-hanjun.guo@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Catalin, On 2014年10月17日 21:36, Hanjun Guo wrote: > It always make sense to initialize CPU0's logical map entry from the > hardware values, so move the initialization of cpu_logical_map(0) > before unflatten_device_tree() which is needed by ACPI code later. > > Acked-by: Olof Johansson > Acked-by: Mark Rutland > Signed-off-by: Hanjun Guo Could you merge this patch first in 3.19? It was acked by Olof and Mark, and it will make sense without ACPI too. Thanks Hanjun > --- > arch/arm64/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index edb146d..8f33f72 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -393,11 +393,11 @@ void __init setup_arch(char **cmdline_p) > > efi_idmap_init(); > > + cpu_logical_map(0) = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > unflatten_device_tree(); > > psci_init(); > > - cpu_logical_map(0) = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > cpu_read_bootcpu_ops(); > #ifdef CONFIG_SMP > smp_init_cpus(); >