From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 1FA3EE008CF; Tue, 18 Nov 2014 06:42:19 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.169 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 50B75E007C0 for ; Tue, 18 Nov 2014 06:42:15 -0800 (PST) Received: by mail-wi0-f169.google.com with SMTP id r20so5832654wiv.0 for ; Tue, 18 Nov 2014 06:42:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=VAnnwgS7XNPblsXvWTxWyfsqxx6wE3VMESavj4LIFxA=; b=Quv5OaSMsUwgb/xYT1q8rgY/eVvjMiDZwa8xBhKzIf1NIGi/slOaDrEwjl+EC+7nmj /EifUu+lWv1TnElvVoHvppti+cP0t7lnnAvzdstKIqoR4v3aH7nMZq/BKF1vbVy+aTUK rjfJg262bcdVsxFSPVwiSCeVlyv/jGZZP9gEFvVAzn6zqFm2PnvoybqwzfRDNzwnydXT NP9Jm4CSczHWkCYdI5Ab6Bm8NCFGuzrOzaIX0b88p+6iJgn06o9YIjW1eygwXruycHg5 zxk7lL53fdwA7bJn/3eRzIei49pcR0/gnAGFLyc33L9lzq2CHaxW56ByErdujTT/O2cr S7Xw== X-Gm-Message-State: ALoCoQn+//eokfhr9Aoyd72rwnzViCoVfv4aHvuwu7dDFpR/FrK/Ud4YraRPi7RUtOnodjpL4+1M X-Received: by 10.180.211.108 with SMTP id nb12mr4523962wic.76.1416321735024; Tue, 18 Nov 2014 06:42:15 -0800 (PST) Received: from [192.168.2.65] ([83.217.123.106]) by mx.google.com with ESMTPSA id wa10sm51406962wjc.8.2014.11.18.06.42.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Nov 2014 06:42:13 -0800 (PST) Message-ID: <546B5AC5.4030005@intel.com> Date: Tue, 18 Nov 2014 14:42:13 +0000 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Barros Pena, Belen" References: <546A0F46.4070708@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] michaelw/toaster/new-build-button-v2 X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 14:42:19 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Thanks. I've pushed that fix for that to the same branch. On 18/11/14 12:29, Barros Pena, Belen wrote: > Hi Michael, > > This is working really nicely. I just found a couple of tiny issues with > the layout. There is a patch here > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/n > ew-build-button2&id=dbd175cf9d74ce57382444baab0d516562397ab6 > > I've also found a small problem with the project input field: the save > button should be disabled whenever the field is empty, which is not the > case right now. This is how I tested it: in the new build dialog, click on > the 'change' icon, select a different project and then, without clicking > 'save', delete the project name from the input field. The 'save' button is > still enabled (it should be disabled) and, if you click it, it will set > the project to the project name you just deleted from the input field, > which is a bit weird. We can avoid this kind of thing (and also having to > show error messages) by disabling the buttons when their input fields are > empty. > > Thanks!! > > Belén > > > > On 17/11/2014 15:07, "Michael Wood" wrote: > >> poky-contrib michaelw/toaster/new-build-button-v2 >> >> bitbake: toaster: project page remove additional tooltip for Change pencil >> bitbake: toaster: libtoaster: fix missing tooltip hover on pencil icon >> bitbake: toaster: Add New Build Button feature >> bitbake: toaster: libtoaster: Add getProjectInfo utility function >> bitbake: toaster: Create libtoaster.js with some utility functions >> >> Thanks, >> >> Michael >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster