From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: ian.campbell@citrix.com, tim@xen.org,
Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU
Date: Tue, 18 Nov 2014 15:00:37 +0000 [thread overview]
Message-ID: <546B5F15.5060702@linaro.org> (raw)
In-Reply-To: <54535E240200007800043DAC@mail.emea.novell.com>
Hi Jan,
On 10/31/2014 09:02 AM, Jan Beulich wrote:
>>>> On 30.10.14 at 19:51, <julien.grall@linaro.org> wrote:
> The naming suggests that the #if really should be around just the
> gic_version field (with a dummy field in the #else case to be C89
> compatible, e.g. a zero width unnamed bitfield) and the
> corresponding #define-s above, ...
Not really related to this patch... but the way to improve it (via
extending createdomain).
I need to create an empty structure. Is the dummy field really needed?
If so, did you meant?
struct
{
int :0;
}
The C spec declare this kind of structure as undefined. Would an empty
structure and used it be better?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-11-18 15:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 18:51 [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU Julien Grall
2014-10-31 9:02 ` Jan Beulich
2014-10-31 11:23 ` Julien Grall
2014-10-31 13:37 ` Jan Beulich
2014-10-31 13:53 ` Julien Grall
2014-10-31 15:12 ` Jan Beulich
2014-11-01 18:56 ` Julien Grall
2014-11-18 15:00 ` Julien Grall [this message]
2014-11-18 15:10 ` Ian Jackson
2014-11-18 15:26 ` Julien Grall
2014-11-18 15:35 ` Ian Jackson
2014-11-18 15:49 ` Empty struct in public headers Was: " Julien Grall
2014-11-18 16:21 ` Ian Campbell
2014-11-18 16:29 ` Julien Grall
2014-11-18 16:31 ` Ian Campbell
2014-11-18 16:15 ` Jan Beulich
2014-11-18 16:19 ` Julien Grall
2014-11-18 16:43 ` Jan Beulich
2014-10-31 17:45 ` Stefano Stabellini
2014-10-31 18:15 ` Julien Grall
2014-10-31 18:24 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546B5F15.5060702@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.