From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for Xen 4.5] xen/arm: Add support for GICv3 for domU Date: Tue, 18 Nov 2014 15:00:37 +0000 Message-ID: <546B5F15.5060702@linaro.org> References: <1414695092-20761-1-git-send-email-julien.grall@linaro.org> <54535E240200007800043DAC@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XqkGq-0001dI-Bd for xen-devel@lists.xenproject.org; Tue, 18 Nov 2014 15:00:44 +0000 Received: by mail-lb0-f174.google.com with SMTP id w7so233830lbi.19 for ; Tue, 18 Nov 2014 07:00:42 -0800 (PST) In-Reply-To: <54535E240200007800043DAC@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: ian.campbell@citrix.com, tim@xen.org, Vijaya Kumar K , Ian Jackson , stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org Hi Jan, On 10/31/2014 09:02 AM, Jan Beulich wrote: >>>> On 30.10.14 at 19:51, wrote: > The naming suggests that the #if really should be around just the > gic_version field (with a dummy field in the #else case to be C89 > compatible, e.g. a zero width unnamed bitfield) and the > corresponding #define-s above, ... Not really related to this patch... but the way to improve it (via extending createdomain). I need to create an empty structure. Is the dummy field really needed? If so, did you meant? struct { int :0; } The C spec declare this kind of structure as undefined. Would an empty structure and used it be better? Regards, -- Julien Grall