From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.g.wood@intel.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id EB4E4E008E2; Tue, 18 Nov 2014 07:08:03 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
	* -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,
	low *      trust
	*      [74.125.82.51 listed in list.dnswl.org]
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id AD50CE0091F
	for <toaster@yoctoproject.org>; Tue, 18 Nov 2014 07:07:55 -0800 (PST)
Received: by mail-wg0-f51.google.com with SMTP id k14so8603953wgh.38
	for <toaster@yoctoproject.org>; Tue, 18 Nov 2014 07:07:54 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
	:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=x6QeATvEO/zaaVK+q4pF3Yu58e/VqSQV96o7VYh2MkM=;
	b=VDzfFOAvYB73O06TPzsb2cCKnAnb4uLjRkUq3AdlYhPX4H0TRdykS41YKatYMp0j79
	NOnJmhH1P65Hh4+lcj1GtjaqTkaoG4ocEiEiCIDrD23R/PjUKd74SVsvtU74e71u33Lu
	EewxZljnhLKuwrljBI4cu9PfriJt27hDhIJdH7fWnDfvLKDnRJs/JHNNJqwtErZXEYih
	MSAAZe1St4oe8OtCENXSnwplfgIZQMB+iCn4f0tHnDnOXis3M78x6XqKWtpeiUUYBI3b
	lwkgkomfLrbivH+MX/l/oHbkKQ37dSIVmR7UBhFJzbeZ+/hIJfQ6KGjYzW4MTVo3MKDF
	8aCQ==
X-Gm-Message-State: ALoCoQmmOxToQVpsgofZgiT2/4v7Q+ysBvXNsfHIFCpjSCKbemblErehVjPuxqDjIzFiCDmMjayG
X-Received: by 10.180.198.164 with SMTP id jd4mr4608095wic.42.1416323273951;
	Tue, 18 Nov 2014 07:07:53 -0800 (PST)
Received: from [192.168.2.65] ([83.217.123.106])
	by mx.google.com with ESMTPSA id
	ek9sm19860146wib.21.2014.11.18.07.07.52 for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Tue, 18 Nov 2014 07:07:52 -0800 (PST)
Message-ID: <546B60C8.7040902@intel.com>
Date: Tue, 18 Nov 2014 15:07:52 +0000
From: Michael Wood <michael.g.wood@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: "Barros Pena, Belen" <belen.barros.pena@intel.com>, 
	"toaster@yoctoproject.org" <toaster@yoctoproject.org>
References: <D08A493C.4E1D5%belen.barros.pena@intel.com>
	<546A4285.8020805@intel.com>
	<D0910872.4E570%belen.barros.pena@intel.com>
In-Reply-To: <D0910872.4E570%belen.barros.pena@intel.com>
Subject: Re: [review-request] bbarrosp/all-pages
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2014 15:08:04 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

On 18/11/14 14:33, Barros Pena, Belen wrote:
>> commit e8107bbb44afeec888667f5239afa33bf71235b4
>>
>> <td class="target">
>>                   {{o.name}}
>> -                <a target="_blank"
>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>> get-info"></i></a>
>> +                {% if o.name %}
>> +                    <a target="_blank"
>> href="{{o.get_layersource_view_url}}"><i class="icon-share
>> get-info"></i></a>
>> +                {% endif%}
>>           </td>
>>
>> A tiny tiny niggle would be that {{o.name}} could be inside the if
>> statement so that when you read it, it's not "use this var...  now check
>> it exists"
> When you put it that way, it does sound silly.
>
>
>> the templating engine will do the right thing so it's just a
>> reading issue.
>>
>> commit 8c38eec9e48e2bcf492584f70991056a3513c479
> You mean like this?
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/a
> ll-pages-v2&id=90c6ebf2647acd2e8feb0404700dd87467a4f8aa
Yep. looks good to me.

Michael