From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 1/4] xen: arm: Add earlyprintk for McDivitt. Date: Tue, 18 Nov 2014 16:59:46 +0000 Message-ID: <546B7B02.6050104@linaro.org> References: <1416329045.17982.27.camel@citrix.com> <1416329088-23328-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1416329088-23328-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: Pranavkumar Sawargaonkar , Clark Laughlin , tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 11/18/2014 04:44 PM, Ian Campbell wrote: > Signed-off-by: Ian Campbell > --- > xen/arch/arm/Rules.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk > index 572d854..ef887a5 100644 > --- a/xen/arch/arm/Rules.mk > +++ b/xen/arch/arm/Rules.mk > @@ -95,6 +95,12 @@ EARLY_PRINTK_BAUD := 115200 > EARLY_UART_BASE_ADDRESS := 0x1c020000 > EARLY_UART_REG_SHIFT := 2 > endif > +ifeq ($(CONFIG_EARLY_PRINTK), xgene-mcdivitt) > +EARLY_PRINTK_INC := 8250 > +EARLY_PRINTK_BAUD := 9600 EARLY_PRINTK_BAUD is not necessary as we don't use the initialization function (EARLY_PRINTK_INIT_UART is not set). With the EARLY_PRINTK_BAUD dropped, this could be merged with the xgene-storm early printk (I didn't really understand why the baud rate is different). But I don't think it's 4.5 material. Regards, -- Julien Grall