From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yerden Zhumabekov <e_zhumabekov-8EHiFRVJVgQ@public.gmane.org>
Subject: Re: [PATCH v4 3/5] hash: add fallback to software CRC32
	implementation
Date: Tue, 18 Nov 2014 23:58:51 +0600
Message-ID: <546B88DB.3010207@sts.kz>
References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz>
 <cover.1416318389.git.e_zhumabekov@sts.kz>
 <a875a94021448514bfbcf1409e4303cde50882f3.1416318389.git.e_zhumabekov@sts.kz>
 <20141118144138.GB32375@hmsreliant.think-freely.org>
 <546B607B.9030808@sts.kz>
 <20141118160005.GC32375@hmsreliant.think-freely.org>
 <546B7E2D.7050705@sts.kz>
 <20141118174619.GE32375@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20141118174619.GE32375-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>


18.11.2014 23:46, Neil Horman =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> On Tue, Nov 18, 2014 at 11:13:17PM +0600, Yerden Zhumabekov wrote:
>> 18.11.2014 22:00, Neil Horman =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>
>>> You need to edit the makefile so that the compiler gets passed the op=
tion
>>> -msse42.  That way it will know to emit sse42 instructions. It will a=
lso allow
>>> you to remove the ifdef from the include file
>> In this case, I guess there are two options:
>> 1) modify all makefiles which use librte_hash
>> 2) move all function bodies from rte_hash_crc.h to separate module,
>> leaving prototype definitions there only.
>>
>> Everybody's up for the second option? :)
>>
> Crud, you're right, I didn't think about the header inclusion issue.  I=
s it
> worth adding the jump to enable the dynamic hash selection?

If I understood you correctly - I've already added a function to
dynamically change the CRC32 implementation in the runtime,
rte_hash_crc_set_alg(). I can rework patches once again, if everybody's
fine with the separate module.

--=20
Sincerely,

Yerden Zhumabekov
State Technical Service
Astana, KZ