All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/tvheadend: Remove tabs
Date: Tue, 18 Nov 2014 22:01:48 +0100	[thread overview]
Message-ID: <546BB3BC.50002@mind.be> (raw)
In-Reply-To: <1416140787-18038-3-git-send-email-bernd.kuhls@t-online.de>

On 16/11/14 13:26, Bernd Kuhls wrote:
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

 This looks more like adding tabs than removing them...

 But actually:

> ---
>  package/tvheadend/tvheadend.mk |   24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/package/tvheadend/tvheadend.mk b/package/tvheadend/tvheadend.mk
> index b0038c8..ac3a557 100644
> --- a/package/tvheadend/tvheadend.mk
> +++ b/package/tvheadend/tvheadend.mk
> @@ -35,18 +35,18 @@ endif
>  TVHEADEND_DEPENDENCIES += dtv-scan-tables
>  
>  define TVHEADEND_CONFIGURE_CMDS
> -	(cd $(@D);				\
> -	 $(TARGET_CONFIGURE_OPTS)		\
> -	 $(TARGET_CONFIGURE_ARGS)		\
> -	 ./configure				\
> -	 --prefix=/usr				\
> -	 --arch="$(ARCH)"			\
> -	 --cpu="$(BR2_GCC_TARGET_CPU)"		\
> -	 --python="$(HOST_DIR)/usr/bin/python"	\
> -	 --disable-dvbscan			\
> -	 --enable-bundle			\
> -	 --disable-libffmpeg_static		\
> -	 $(TVHEADEND_CONF_OPTS)			\
> +	(cd $(@D); \

 Why don't you remove the redundant parenthesis and avoid one indent level?

> +		$(TARGET_CONFIGURE_OPTS) \
> +		$(TARGET_CONFIGURE_ARGS) \
> +		./configure \

 IMHO it would be nicer if everything below would get an additional indent level.


 Regards,
 Arnout

> +		--prefix=/usr \
> +		--arch="$(ARCH)" \
> +		--cpu="$(BR2_GCC_TARGET_CPU)" \
> +		--python="$(HOST_DIR)/usr/bin/python" \
> +		--disable-dvbscan \
> +		--enable-bundle \
> +		--disable-libffmpeg_static \
> +		$(TVHEADEND_CONF_OPTS) \
>  	)
>  endef
>  
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-11-18 21:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16 12:26 [Buildroot] [PATCH 1/3] package/tvheadend: Bump version Bernd Kuhls
2014-11-16 12:26 ` [Buildroot] [PATCH 2/3] package/tvheadend: add support for host-python3 Bernd Kuhls
2014-11-16 12:26 ` [Buildroot] [PATCH 3/3] package/tvheadend: Remove tabs Bernd Kuhls
2014-11-18 21:01   ` Arnout Vandecappelle [this message]
2014-11-18 21:59 ` [Buildroot] [PATCH 1/3] package/tvheadend: Bump version Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546BB3BC.50002@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.