All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Eichenberger <stefan.eichenberger@netmodule.com>
To: ChenQi <Qi.Chen@windriver.com>,
	"yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: Busybox sh link
Date: Wed, 19 Nov 2014 10:08:25 +0100	[thread overview]
Message-ID: <546C5E09.5080705@netmodule.com> (raw)
In-Reply-To: <546C320E.2010104@windriver.com>

On 11/19/2014 07:00 AM, ChenQi wrote:
> On 11/19/2014 12:34 AM, Stefan Eichenberger wrote:
>> On 11/18/2014 04:07 AM, ChenQi wrote:
>>> On 11/17/2014 10:07 PM, Stefan Eichenberger wrote:
>>>> Hello all
>>>>
>>>> I have a question regarding busybox and sh. If I want to install 
>>>> bash together with busybox ash, yocto does not consider the 
>>>> ALTERNATIVE_PRIORITY in each case (e.g. if bash is installed before 
>>>> busybox). The problem is that do_install of busybox creates a link 
>>>> to busybox.nosuid. Is there a reason for that? Shouldn't 
>>>> update-alternatives create that link for us? There is already a 
>>>> patch available that targets this problem 
>>>> (467b19efbaa9c0cb04d2665e8cd9a0919849a5ed ) but it only works if 
>>>> ash is completely disabled in the busybox config.
>>>>
>>>> So the main question is, wouldn't it be possible to remove this 
>>>> lines completely?
>>>>
>>>> Regards,
>>>> Stefan
>>>>
>>>>
>>>
>>> I can confirm that this is indeed a problem. And we need to fix this.
>>> I think the reason for this line is mainly to make 'busybox' provide 
>>> '/bin/sh' so that do_rootfs would succeed.
>>>
>>> Regards,
>>> Chen Qi
>>
>> Probably I miss something but I don't understand why do_rootfs fails 
>> if the link is not provided? Isn't the link created anyhow during 
>> package installation in the postinstall script with 
>> update-alternatives if necessary?
>>
>> For testing I removed the link creation temporary from the recipe and 
>> built the core-image-minimal for qemux86, it was creating the link 
>> correctly in this case.
>>
>> Regards,
>> Stefan
>>
>>
>
> Hi Stefan,
>
> I did some testing, and could not reproduce the problem.
> I then realized that as the sh link is managed by ALTERNATIVES 
> mechanism, it will always point to bash instead of busybox.
>
> I tested it by the following steps:
> 1. build core-image-minimal with bash installed
> 2. reinstall bash
> 3. reinstall busybox
>
> So I think the current code is right.
>
> I'm not sure if I missed something. If so, could you please provide 
> more information?
>
> Best Regards,
> Chen Qi

Hi Chen,

You are right, sorry! I think I figured out what I've missed. On an 
image I have disabled busybox ash completely, therefore I didn't saw the 
update-alternative running for sh. Because it was an older version of 
yocto without the above patch, I've got an invalid image. I then tough 
the same problem would appear if I enable busybox ash again, but in this 
case update-alternative would run, so the problem wouldn't appear.

Sorry for the false alarm!

Regards,
Stefan





      reply	other threads:[~2014-11-19  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17 14:07 Busybox sh link Stefan Eichenberger
2014-11-18  3:07 ` ChenQi
2014-11-18 16:34   ` Stefan Eichenberger
2014-11-19  6:00     ` ChenQi
2014-11-19  9:08       ` Stefan Eichenberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546C5E09.5080705@netmodule.com \
    --to=stefan.eichenberger@netmodule.com \
    --cc=Qi.Chen@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.