From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?S2FpIFdhc3NlcmLDpGNo?= Subject: Re: [PATCH 11/11] drm/radeon: update the VM after setting BO address v3 Date: Wed, 19 Nov 2014 16:43:46 +0100 Message-ID: <546CBAB2.5040808@dev.carbon-project.org> References: <1416402089-2366-1-git-send-email-deathsimple@vodafone.de> <1416402089-2366-11-git-send-email-deathsimple@vodafone.de> <546C9845.8080600@dev.carbon-project.org> <546C9C8D.9060902@vodafone.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0586202665==" Return-path: Received: from blackmesa.kw-serverwartung.de (blackmesa.kw-serverwartung.de [78.46.90.79]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DFE36EEDC for ; Wed, 19 Nov 2014 07:44:00 -0800 (PST) In-Reply-To: <546C9C8D.9060902@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0586202665== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UraC0LfEISJe16uV8lUJDQhf3sX00hl5m" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UraC0LfEISJe16uV8lUJDQhf3sX00hl5m Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dear Christian, Christian K=C3=B6nig wrote on 19.11.2014 14:35: > Am 19.11.2014 um 14:16 schrieb Kai Wasserb=C3=A4ch: >> Dear Christian, >> Christian K=C3=B6nig wrote on 19.11.2014 14:01: >>> From: Christian K=C3=B6nig >>> >>> This way the necessary VM update is kicked off immediately >>> if all BOs involved are in GPU accessible memory. >>> >>> v2: fix vm lock >>> v3: immediately update unmaps as well >>> >>> Signed-off-by: Christian K=C3=B6nig >>> --- >>> drivers/gpu/drm/radeon/radeon_gem.c | 64 ++++++++++++++++++++++++++= +++++++++++ >>> 1 file changed, 64 insertions(+) >> Is this a fix for >> which I bisected to the v2 of this patch >> () as >> present on the drm-next-3.19-wip branch? >=20 > Yes and no, it was actually the patch before this one which triggered t= he > problem. The last one just made it much more likely to appear. >=20 > Please test the whole patchset on top of Dave's drm-next tree if your p= roblem > still exists. this is still bad: [ 117.818981] BUG: unable to handle kernel paging request at ffffeae3801= 564d8 [ 117.819019] IP: [] virt_to_head_page+0x33/0x4a [ 117.819049] PGD 0 [ 117.819059] Oops: 0000 [#1] SMP [ 117.819077] Modules linked in: serpent_avx_x86_64 serpent_sse2_x86_64 serpent_generic blowfish_x86_64 blowfish_common ecb cmac sha512_ssse3 sha512_generic sha256_ssse3 sha256_generic nfsd auth_rpcgss oid_registry = nfs_acl nfs lockd grace fscache sunrpc nls_utf8 nls_cp437 vfat fat snd_hda_codec_= realtek snd_hda_codec_generic snd_hda_codec_hdmi iTCO_wdt iTCO_vendor_support rad= eon snd_hda_intel x86_pkg_temp_thermal snd_hda_controller drm_kms_helper ttm snd_hda_codec snd_hwdep snd_pcm_oss mei_me video snd_mixer_oss i2c_i801 c= oretemp snd_pcm mei lpc_ich mfd_core evdev joydev processor snd_timer snd soundco= re button serio_raw kvm_intel kvm pcspkr efivars fuse parport_pc ppdev lp pa= rport ext4 crc16 mbcache jbd2 btrfs xor raid6_pq twofish_generic twofish_avx_x8= 6_64 twofish_x86_64_3way twofish_x86_64 twofish_common [ 117.819454] xts af_alg hid_generic usbhid dm_crypt dm_mod microcode hid_lg_g710_plus(O) hid sg sr_mod sd_mod cdrom crct10dif_pclmul crc32c_in= tel ghash_clmulni_intel aesni_intel aes_x86_64 lrw gf128mul glue_helper ablk_= helper cryptd ahci libahci libata atl1c thermal fan thermal_sys [ 117.819587] CPU: 1 PID: 1959 Comm: Dreamfall Chapt Tainted: G = O 3.18.0-rc4-citadel-airlied-drm-next-with-ck-patches.0.1 #1 [ 117.819634] Hardware name: Gigabyte Technology Co., Ltd. To be filled = by O.E.M./Z77-DS3H, BIOS F11a 11/13/2013 [ 117.819673] task: ffff8800d4417650 ti: ffff8800d21a0000 task.ti: ffff8= 800d21a0000 [ 117.819702] RIP: 0010:[] [] virt_to_head_page+0x33/0x4a [ 117.819737] RSP: 0018:ffff8800d21a3cf0 EFLAGS: 00010086 [ 117.819758] RAX: ffffeae3801564d8 RBX: 0000000000000286 RCX: 000077ff8= 0000000 [ 117.819787] RDX: ffffea0000000000 RSI: ffff8800d21a3d30 RDI: ffffc9000= 61cd000 [ 117.819815] RBP: ffffc900061cd000 R08: 0000000000000000 R09: ffff88040= 7859008 [ 117.819843] R10: ffff880407858fe0 R11: 000000000007ffff R12: ffffffffa= 0602de8 [ 117.819870] R13: ffff880407858000 R14: ffff88039f261ac0 R15: ffff88040= 3d876c0 [ 117.819898] FS: 00007f10c309b780(0000) GS:ffff88041ec40000(0000) knlGS:0000000000000000 [ 117.819930] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 117.819952] CR2: ffffeae3801564d8 CR3: 00000000dcad1000 CR4: 000000000= 01407e0 [ 117.819979] Stack: [ 117.819988] ffffffff8111eda1 ffff8800d21a3de0 0000000000000000 ffff88= 00d21a3d30 [ 117.820022] ffffffffa0602de8 ffffc900061cd000 00000000a060245a 000000= 0000000000 [ 117.820055] ffffc900061ce0a8 ffff8800d21a3d58 ffff8800d4417650 000000= 0000001e7d [ 117.820089] Call Trace: [ 117.820101] [] ? kfree+0x2e/0x6d [ 117.820137] [] ? radeon_gem_va_ioctl+0x28c/0x2d3 [r= adeon] [ 117.820176] [] ? radeon_gem_create_ioctl+0xa4/0xc3 = [radeon] [ 117.820207] [] ? drm_ioctl+0x35b/0x3e1 [ 117.820238] [] ? radeon_gem_get_tiling_ioctl+0x8e/0= x8e [radeon] [ 117.820270] [] ? _raw_spin_unlock_irqrestore+0xc/0x= d [ 117.820303] [] ? radeon_drm_ioctl+0x4b/0x7a [radeon= ] [ 117.820331] [] ? do_vfs_ioctl+0x34e/0x404 [ 117.820355] [] ? vfs_read+0xbc/0xea [ 117.820377] [] ? SyS_ioctl+0x51/0x77 [ 117.820398] [] ? system_call_fastpath+0x12/0x17 [ 117.820423] Code: 00 00 80 ff 77 00 00 48 01 fa 48 0f 42 0d 78 99 6f 0= 0 48 8d 04 11 48 ba 00 00 00 00 00 ea ff ff 48 c1 e8 0c 48 6b c0 38 48 01 d0 <48>= 8b 10 80 e6 80 74 0e 48 8b 50 30 48 8b 08 80 e5 80 48 0f 45 [ 117.820582] RIP [] virt_to_head_page+0x33/0x4a [ 117.820608] RSP [ 117.820622] CR2: ffffeae3801564d8 [ 117.838461] ---[ end trace a6e2a6aa1df3196f ]--- I've used Dave Airlie's drm-next as a base (commit d0d6c524bf1d72e6d64134c3a315b77deecc9252) and "git am"-applied your serie= s (no issues, applied cleanly) on top. Steam games are still entering the defun= ct state as soon as the 3D engines are fired up on a kernel built from that = source tree. This is with (Debian testing as a base): GPU: Hawaii PRO [Radeon R9 290] (ChipID =3D 0x67b1) Mesa: Git:master/b69c7c5dac libdrm: Git:master/00847fa48b LLVM: SVN:trunk/r222254 (3.6 devel) X.Org: 2:1.16.1-1 Firmware: # 9e05820da42549ce9c89d147cf1f8e19 hawaii_ce.bin # c8bab593090fc54f239c8d7596c8d846 hawaii_mc.bin # 3618dbb955d8a84970e262bb2e6d2a16 hawaii_me.bin # c000b0fc9ff6582145f66504b0ec9597 hawaii_mec.bin # 0643ad24b3beff2214cce533e094c1b7 hawaii_pfp.bin # ba6054b7d78184a74602fd81607e1386 hawaii_rlc.bin # 11288f635737331b69de9ee82fe04898 hawaii_sdma.bin # 284429675a5560e0fad42aa982965fc2 hawaii_smc.bin libclc: Git:master/7f6f5bff1f DDX: 1:7.5.0-1 Let me know, if you need something else; see also the original thread for further i= nformation. Cheers, Kai --UraC0LfEISJe16uV8lUJDQhf3sX00hl5m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQGcBAEBCgAGBQJUbLq3AAoJEKMJ12zh3lnSTbIMAIFO4aDbg0DcYfOba1Y7tNT5 i9I2XEzUfcumaxo0xPtEY2YC6Qq+DRCxziUfBYsv+zhBWckAa+ISqwPJf/fz5qR5 XqlI8j17Lh2IoGKjkBkUWwFrtEJM+ezgCKzcM4hBdw5BuNYUP/Up4/Omq65gUeUl n/GRSqgEQisHVOuMCdRDPzwNO0wQZaOPTyrTJ0pMUO9UUQyX8QIRbzw4SZAmCsiO vEFMzOPGb+M1HJgc7Y1HQn1BEj2DRXW5K/xY5JOiiEDKbRYgCZuvfOm+FG+nDtVg fPGwBl6Ui4VxPh09FDNy/iSUU0Sbt6VjMlHneRhyLgUkqabK8NponL2vzEQflalx EI4Ef+yDK9Y5EhtNlUJxWMBUMpJkNR1KSRuDvFNbgKJlBRABaJsCJy8OMtTnN5FA HCslxWQJoBgsu3kyCKjwgVWQzykgtEL8pmbSvaE7OkWOLPItB79Ak6PVfqjzV8un LNSlSDfFA2+MHaylZ2lnZ3gp3mMc/C344kFeu5bKVQ== =3NRu -----END PGP SIGNATURE----- --UraC0LfEISJe16uV8lUJDQhf3sX00hl5m-- --===============0586202665== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0586202665==--