All of lore.kernel.org
 help / color / mirror / Atom feed
From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call
Date: Wed, 19 Nov 2014 18:41:27 +0100	[thread overview]
Message-ID: <546CD647.2090109@samsung.com> (raw)
In-Reply-To: <1416414090-4058-2-git-send-email-suriyan.r@gmail.com>

Hello,

On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
> The USB host code was missing gpio_request() calls before using the gpio
> functions, causing errors to be printed out.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>
> ---
>
> Changes in v1:
> - Added gpio_request() call in board_gpio_init()
>
>   board/samsung/odroid/odroid.c | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index f7396ab..a2c008e 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -382,6 +382,17 @@ static void board_gpio_init(void)
>   	gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
>   	gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
>   	gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> +#ifdef CONFIG_CMD_USB
> +	/* USB3503A Reference frequency */
> +	gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq");
> +
> +	/* USB3503A Connect */
> +	gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect");
> +
> +	/* USB3503A Reset */
> +	gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset");
> +#endif
>   }
>
>   static int pmic_init_max77686(void)
> @@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init)
>
>   	p_pmic = pmic_get("MAX77686_PMIC");
>   	if (p_pmic && !pmic_probe(p_pmic)) {
> -		max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
>   		max77686_set_buck_voltage(p_pmic, 8, 750000);
>   		max77686_set_buck_voltage(p_pmic, 8, 3300000);
> -		max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
>   	}
>
>   #endif
>

The first commit needs to be changed but for this one:

Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

  reply	other threads:[~2014-11-19 17:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 16:21 [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Suriyan Ramasami
2014-11-19 16:21 ` [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
2014-11-19 17:41   ` Przemyslaw Marczak [this message]
2014-11-20  8:41   ` Minkyu Kang
2014-11-20 15:05     ` Suriyan Ramasami
2014-11-19 17:39 ` [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Przemyslaw Marczak
2014-11-19 18:29   ` Suriyan Ramasami
2014-11-19 18:40     ` Przemyslaw Marczak
2014-11-19 18:47       ` Suriyan Ramasami
2014-11-19 19:26         ` Przemyslaw Marczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546CD647.2090109@samsung.com \
    --to=p.marczak@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.