All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, luca@coelho.fi,
	Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC] mac80211: allow drivers to provide any statistics
Date: Wed, 19 Nov 2014 09:53:22 -0800	[thread overview]
Message-ID: <546CD912.1090809@candelatech.com> (raw)
In-Reply-To: <20141119174925.GM11482@localhost>

On 11/19/2014 09:49 AM, Bob Copeland wrote:
> On Mon, Nov 17, 2014 at 11:48:06AM +0100, Johannes Berg wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>>
>> In many cases, drivers can filter things like beacons that will
>> skew statistics reported by mac80211. To get correct statistics
>> in these cases, call drivers to obtain statistics and let them
>> override all values, filling values from mac80211 if the driver
>> didn't provide them.
> 
> Neat.
> 
> For mesh, it's handy to have the (somewhat imperfectly specified)
> sta->fail_avg too for drivers that implement all the rate control
> in firmware and thus may not report tx status for all frames.
> 
> At cozybit we had implemented a drv_link_stats driver op (hack) that
> just got last_tx_rate and fail_avg so that the airtime link metric
> could work on such devices; this call could replace that, I hope.


The ethtool stats API could also handle at least some of this,
but it's a bit free-form to program against...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


      reply	other threads:[~2014-11-19 17:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17 10:48 [RFC] mac80211: allow drivers to provide any statistics Johannes Berg
2014-11-17 11:28 ` Luca Coelho
2014-11-17 12:03 ` Arend van Spriel
2014-11-17 12:23   ` Johannes Berg
2014-11-19 17:49 ` Bob Copeland
2014-11-19 17:53   ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546CD912.1090809@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.