All of lore.kernel.org
 help / color / mirror / Atom feed
From: subaparts@yandex.ru (Alexander Sverdlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: ep93xx: add dma_masks for the M2P and M2M DMA controllers
Date: Wed, 19 Nov 2014 18:55:20 +0100	[thread overview]
Message-ID: <546CD988.8010202@yandex.ru> (raw)
In-Reply-To: <1416415519-4903-1-git-send-email-hsweeten@visionengravers.com>

Hi!

On 19/11/14 17:45, H Hartley Sweeten wrote:
> The dma_mask and coherent_dma_mask need to be set or DMA memory allocations
> will fail with error messages like this:
>
>    ep93xx-dma ep93xx-dma-m2p: coherent DMA mask is unset
>
>    ep93xx-dma ep93xx-dma-m2m: coherent DMA mask is unset
>
> Add the missing information to the ep93xx-dma-m2p and ep93xx-dma-m2m
> devices.
>
> This fixes a problem with the sound/soc/edb93xx.c driver not loading
> that was reported by Jeremy Moles.

This repaired the sound on EDB9302-like board for me, so:

> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Reported-by: Jeremy Moles <cubicool@gmail.com>

Tested-by: Alexander Sverdlin <subaparts@yandex.ru>

> Cc: Alexander Sverdlin <subaparts@yandex.ru>
> Cc: Ryan Mallon <rmallon@gmail.com>
> ---
>   arch/arm/mach-ep93xx/dma.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/dma.c b/arch/arm/mach-ep93xx/dma.c
> index d8bfd02..88a4c9b 100644
> --- a/arch/arm/mach-ep93xx/dma.c
> +++ b/arch/arm/mach-ep93xx/dma.c
> @@ -66,11 +66,15 @@ static struct ep93xx_dma_platform_data ep93xx_dma_m2p_data = {
>   	.num_channels		= ARRAY_SIZE(ep93xx_dma_m2p_channels),
>   };
>
> +static u64 ep93xx_dma_m2p_mask = DMA_BIT_MASK(32);
> +
>   static struct platform_device ep93xx_dma_m2p_device = {
>   	.name			= "ep93xx-dma-m2p",
>   	.id			= -1,
>   	.dev			= {
> -		.platform_data	= &ep93xx_dma_m2p_data,
> +		.platform_data		= &ep93xx_dma_m2p_data,
> +		.dma_mask		= &ep93xx_dma_m2p_mask,
> +		.coherent_dma_mask	= DMA_BIT_MASK(32),
>   	},
>   };
>
> @@ -93,11 +97,15 @@ static struct ep93xx_dma_platform_data ep93xx_dma_m2m_data = {
>   	.num_channels		= ARRAY_SIZE(ep93xx_dma_m2m_channels),
>   };
>
> +static u64 ep93xx_dma_m2m_mask = DMA_BIT_MASK(32);
> +
>   static struct platform_device ep93xx_dma_m2m_device = {
>   	.name			= "ep93xx-dma-m2m",
>   	.id			= -1,
>   	.dev			= {
> -		.platform_data	= &ep93xx_dma_m2m_data,
> +		.platform_data		= &ep93xx_dma_m2m_data,
> +		.dma_mask		= &ep93xx_dma_m2m_mask,
> +		.coherent_dma_mask	= DMA_BIT_MASK(32),
>   	},
>   };
>
>

       reply	other threads:[~2014-11-19 17:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1416415519-4903-1-git-send-email-hsweeten@visionengravers.com>
2014-11-19 17:55 ` Alexander Sverdlin [this message]
2014-11-21 17:23 [PATCH] arm: ep93xx: add dma_masks for the M2P and M2M DMA controllers H Hartley Sweeten
2014-11-28 11:35 ` Arnd Bergmann
2014-11-28 22:30   ` Hartley Sweeten
2014-12-01 17:16   ` Hartley Sweeten
2014-12-01 17:58     ` Arnd Bergmann
2014-12-01 21:14       ` Hartley Sweeten
2014-12-04 16:08         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546CD988.8010202@yandex.ru \
    --to=subaparts@yandex.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.