From: Murali Karicheri <m-karicheri2@ti.com>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>, Wolfram Sang <wsa@the-dreams.de>,
<linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map
Date: Wed, 19 Nov 2014 13:02:14 -0500 [thread overview]
Message-ID: <546CDB26.9030609@ti.com> (raw)
In-Reply-To: <20141114221903.GA38539@dtor-ws>
On 11/14/2014 05:19 PM, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov<dtor@chromium.org>
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8a27078..f2bd48d 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
> */
> for (temp = 0; temp< max_host_irqs; temp++) {
> host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
> - if (host_irqs[temp]< 0)
> + if (!host_irqs[temp])
> break;
> }
> if (temp) {
Good catch!
Acked-By: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Texas Instruments
WARNING: multiple messages have this Message-ID (diff)
From: m-karicheri2@ti.com (Murali Karicheri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map
Date: Wed, 19 Nov 2014 13:02:14 -0500 [thread overview]
Message-ID: <546CDB26.9030609@ti.com> (raw)
In-Reply-To: <20141114221903.GA38539@dtor-ws>
On 11/14/2014 05:19 PM, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov<dtor@chromium.org>
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8a27078..f2bd48d 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
> */
> for (temp = 0; temp< max_host_irqs; temp++) {
> host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
> - if (host_irqs[temp]< 0)
> + if (!host_irqs[temp])
> break;
> }
> if (temp) {
Good catch!
Acked-By: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Texas Instruments
next prev parent reply other threads:[~2014-11-19 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 22:19 [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-14 22:19 ` Dmitry Torokhov
2014-11-19 18:02 ` Murali Karicheri [this message]
2014-11-19 18:02 ` Murali Karicheri
2014-12-09 22:38 ` Bjorn Helgaas
2014-12-09 22:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CDB26.9030609@ti.com \
--to=m-karicheri2@ti.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dtor@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.