From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>,
<brcm80211-dev-list@broadcom.com>,
John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] brcmfmac: don't include linux/unaligned/access_ok.h
Date: Wed, 19 Nov 2014 21:36:29 +0100 [thread overview]
Message-ID: <546CFF4D.7010306@broadcom.com> (raw)
In-Reply-To: <1416428298-10000-1-git-send-email-johannes@sipsolutions.net>
On 11/19/14 21:18, Johannes Berg wrote:
> From: Johannes Berg<johannes.berg@intel.com>
>
> This is a specific implementation,<asm/unaligned.h> is the
> multiplexer that has the arch-specific knowledge of which
> of the implementations needs to be used, so include that.
Thanks, Johannes
Maybe it would be good to mention this was found by kbuild test robot.
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Johannes Berg<johannes.berg@intel.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> index b0ae7993e2e8..138691a1365a 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/pcie.c
> @@ -19,10 +19,10 @@
> #include<linux/pci.h>
> #include<linux/vmalloc.h>
> #include<linux/delay.h>
> -#include<linux/unaligned/access_ok.h>
> #include<linux/interrupt.h>
> #include<linux/bcma/bcma.h>
> #include<linux/sched.h>
> +#include<asm/unaligned.h>
>
> #include<soc.h>
> #include<chipcommon.h>
next prev parent reply other threads:[~2014-11-19 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 20:18 [PATCH] brcmfmac: don't include linux/unaligned/access_ok.h Johannes Berg
2014-11-19 20:36 ` Arend van Spriel [this message]
2014-11-19 20:42 ` Johannes Berg
2014-11-19 20:47 ` Arend van Spriel
2014-11-19 20:48 ` Johannes Berg
2014-11-19 20:51 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CFF4D.7010306@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.