From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: David Rientjes <rientjes@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 1/3] mm: sl[aou]b: introduce kmem_cache_zalloc_node()
Date: Thu, 20 Nov 2014 11:47:21 +0300 [thread overview]
Message-ID: <546DAA99.5070402@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1411191545210.32057@chino.kir.corp.google.com>
On 11/20/2014 02:46 AM, David Rientjes wrote:
> On Mon, 10 Nov 2014, Andrey Ryabinin wrote:
>
>> kmem_cache_zalloc_node() allocates zeroed memory for a particular
>> cache from a specified memory node. To be used for struct irq_desc.
>>
>
> Is there a reason to add this for such a specialized purpose to the slab
> allocator? I think it can just be handled for struct irq_desc explicitly.
>
It could be used not only for irq_desc. Grepping sources gave me 7 possible users.
We already have zeroing variants of kmalloc/kmalloc_node/kmem_cache_alloc,
so why kmem_cache_alloc_node is special?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: David Rientjes <rientjes@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 1/3] mm: sl[aou]b: introduce kmem_cache_zalloc_node()
Date: Thu, 20 Nov 2014 11:47:21 +0300 [thread overview]
Message-ID: <546DAA99.5070402@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1411191545210.32057@chino.kir.corp.google.com>
On 11/20/2014 02:46 AM, David Rientjes wrote:
> On Mon, 10 Nov 2014, Andrey Ryabinin wrote:
>
>> kmem_cache_zalloc_node() allocates zeroed memory for a particular
>> cache from a specified memory node. To be used for struct irq_desc.
>>
>
> Is there a reason to add this for such a specialized purpose to the slab
> allocator? I think it can just be handled for struct irq_desc explicitly.
>
It could be used not only for irq_desc. Grepping sources gave me 7 possible users.
We already have zeroing variants of kmalloc/kmalloc_node/kmem_cache_alloc,
so why kmem_cache_alloc_node is special?
next prev parent reply other threads:[~2014-11-20 8:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 12:06 [PATCH 1/3] mm: sl[aou]b: introduce kmem_cache_zalloc_node() Andrey Ryabinin
2014-11-10 12:06 ` Andrey Ryabinin
2014-11-10 12:06 ` [PATCH 2/3] kernel: irq: use a kmem_cache for allocating struct irq_desc Andrey Ryabinin
2014-11-19 23:52 ` David Rientjes
2014-11-20 8:53 ` Andrey Ryabinin
2014-11-10 12:06 ` [PATCH 3/3] kernel: irq: use kmem_cache for allocating struct irqaction Andrey Ryabinin
2014-11-19 23:46 ` [PATCH 1/3] mm: sl[aou]b: introduce kmem_cache_zalloc_node() David Rientjes
2014-11-19 23:46 ` David Rientjes
2014-11-20 8:47 ` Andrey Ryabinin [this message]
2014-11-20 8:47 ` Andrey Ryabinin
2014-11-20 20:03 ` Christoph Lameter
2014-11-20 20:03 ` Christoph Lameter
2014-11-20 22:31 ` David Rientjes
2014-11-20 22:31 ` David Rientjes
2014-11-21 6:29 ` Andrey Ryabinin
2014-11-21 6:29 ` Andrey Ryabinin
2014-11-21 9:57 ` David Rientjes
2014-11-21 9:57 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DAA99.5070402@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.