From: Inki Dae <inki.dae@samsung.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be independent drivers
Date: Thu, 20 Nov 2014 23:10:24 +0900 [thread overview]
Message-ID: <546DF650.4030302@samsung.com> (raw)
In-Reply-To: <CABxcv=msvOkbzZdh3xQ-GUZVioNuLhX_QixCDP8MMs1d3fc4Rg@mail.gmail.com>
Hi Javier,
On 2014년 11월 20일 23:06, Javier Martinez Canillas wrote:
> Hello Inki,
>
> On Thu, Nov 20, 2014 at 2:56 PM, Inki Dae <inki.dae@samsung.com> wrote:
>>> If you try to build exynosdrm as module you will receive errors due to
>>> multiple definitions of init_module, ie module_init/module_*_driver
>>> macros can be used once per module.
>>
>> Ah, right. we had ever tried same way before but failed in same problem.
>> I didn't realize that. Anyway, I will try to find out a better way. I'd
>> really like to remove all register codes of sub drivers from
>> exynos_drm_drv somehow.
>>
>
> Maybe as an immediate fix we can move the platform driver registration
> out of probe as suggested by Andrzej?
>
> I posted an RFC patch a couple of days ago [0] that fixes both the
> deadlock and the infinite loop bug so it would be great if you can
> review/test so I can post a proper patch.
Fantastical timing.:) I gave you a same opinion almost simultaneous.
Check your email thread.
Thanks,
Inki Dae
>
> And then we can look how to better refactor the exynos drm driver.
>
> Best regards,
> Javier
>
> [0]: http://www.spinics.net/lists/linux-samsung-soc/msg39106.html
>
next prev parent reply other threads:[~2014-11-20 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:24 [RFC PATCH v3 0/4] separeate sub drivers into independent drivers Inki Dae
2014-11-20 10:24 ` [RFC PATCH v3 1/4] drm/exynos: make kms drivers to be " Inki Dae
2014-11-20 13:19 ` Andrzej Hajda
2014-11-20 13:56 ` Inki Dae
2014-11-20 14:06 ` Javier Martinez Canillas
2014-11-20 14:10 ` Inki Dae [this message]
2014-11-20 14:23 ` Andrzej Hajda
2014-11-20 14:37 ` Inki Dae
2014-11-21 8:39 ` Andrzej Hajda
2014-11-20 10:24 ` [RFC PATCH v3 2/4] drm/exynos: make non kms drivers to be indenpendent drivers Inki Dae
2014-11-20 10:24 ` [RFC PATCH v3 3/4] drm/exynos: make vidi driver to be independent driver Inki Dae
2014-11-20 10:24 ` [RFC PATCH v3 4/4] drm/exynos: clean up machine compatible string check Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DF650.4030302@samsung.com \
--to=inki.dae@samsung.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javier@dowhile0.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.