Re: [PATCH v2 for 4.5] xl: Return proper error codes for block-attach and block-detach

[George Dunlap <george.dunlap@eu.citrix.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 11/20/2014 03:56 PM, Ian Campbell wrote:
> On Thu, 2014-11-20 at 15:51 +0000, George Dunlap wrote:
>> On 11/20/2014 03:47 PM, Ian Campbell wrote:
>>> On Mon, 2014-11-17 at 12:36 +0000, George Dunlap wrote:
>>>> On 11/14/2014 11:12 AM, Ian Campbell wrote:
>>>>> On Thu, 2014-11-13 at 19:04 +0000, George Dunlap wrote:
>>>>>> Return proper error codes on failure so that scripts can
>>>>>> tell whether the command completed properly or not.
>>>>>> 
>>>>>> Also while we're at it, normalize init and dispose of 
>>>>>> libxl_device_disk structures.  This means calling init
>>>>>> and dispose in the actual functions where they are
>>>>>> declared.
>>>>>> 
>>>>>> This in turn means changing
>>>>>> parse_disk_config_multistring() to not call
>>>>>> libxl_device_disk_init.  And that in turn means changes
>>>>>> to callers of parse_disk_config().
>>>>>> 
>>>>>> It also means removing libxl_device_disk_init() from 
>>>>>> libxl.c:libxl_vdev_to_device_disk().  This is only
>>>>>> called from xl_cmdimpl.c.
>>>>>> 
>>>>>> Signed-off-by: George Dunlap
>>>>>> <george.dunlap@eu.citrix.com> --- CC: Ian Campbell
>>>>>> <ian.campbell@citrix.com> CC: Ian Jackson
>>>>>> <ian.jackson@citrix.com> CC: Wei Liu 
>>>>>> <wei.liu2@citrix.com> CC: Konrad Wilk 
>>>>>> <konrad.wilk@oracle.com>
>>>>>> 
>>>>>> Release justification: This is a bug fix.  It's a fairly 
>>>>>> minor one, but it's also a very simple one.
>>>>>> 
>>>>>> v2: - Restructure functions to make sure init and dispose
>>>>>> are properly called.
>>>>> Sadly this bit has somewhat reduced the truth of the
>>>>> second half of your release justification, since the patch
>>>>> is a fair bit more subtle though. Although IMHO it hasn't
>>>>> invalidated the case for taking the patch for 4.5 (modulo
>>>>> comments below).
>>>> 
>>>> Well, I think we can take the hacky short-term fix I posted 
>>>> before, which is simple, and do a proper fix after the 4.6
>>>> dev window opens up; or we can do a more complete fix now.
>>> 
>>> Specifically the "hacky short-term fix" is 
>>> <1415813493-25330-1-git-send-email-george.dunlap@eu.citrix.com>
>>> ?
>> 
>> Yes -- the one you found somewhat wanting. :-)
>> 
>>> I could live with that, perhaps with the commit log explaining
>>> that a little.
>> 
>> Do you want to add that, or shall I add it and re-submit?
> 
> If you provide the text I'll just fold it in, unless having written
> it you find invoking send-email to be so trivial it's actually
> easier.

Unfortunately I think I clobbered v1 in my git tree while developing
v2.  It probably hasn't been garbage collected yet, but I'll just
reply to v1 with an updated changelog.

 -George

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCgAGBQJUbg/SAAoJELIVx6fHhBvt7CUIAI75XUObbYy0/Zkinx2eVcLE
d+fXSkVFWtwPPI2bfw3DyLtbMzAGxeNLhwwuLZ47b1ROam7fDcMzRp9t36NpetkY
E+NoBk7chO8sD8lveGukipNiX0qTSKVQAc721CHwgO3L3yIw7t4iSsylR0Ntzew1
twiL68v1vwC/N70PJYSzW0v1dFQODX7YV5RreFZ+Hon6og8dNvKmlRojPC77Qid0
kAEiL2JouKrQ48ONr1cKKPWHJqNFL3+pZHbZCi9d+OF0pmOhlaVXZFccLlr26xq+
SMQx0rLyTQF6rJRUaQ0zVgMK82BxjVWXO5rIPQggnwwY0ILaYY9YmmPWw86kD0M=
=04qs
-----END PGP SIGNATURE-----