From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers Date: Thu, 20 Nov 2014 16:15:05 +0000 Message-ID: <546E1389.1070304@linaro.org> References: <1416341031-6204-1-git-send-email-julien.grall@linaro.org> <1416499682.14429.41.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XrUNy-00084y-Uv for xen-devel@lists.xenproject.org; Thu, 20 Nov 2014 16:15:11 +0000 Received: by mail-ee0-f47.google.com with SMTP id e49so105621eek.6 for ; Thu, 20 Nov 2014 08:15:07 -0800 (PST) In-Reply-To: <1416499682.14429.41.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, Don Slutz List-Id: xen-devel@lists.xenproject.org Hi Ian, On 11/20/2014 04:08 PM, Ian Campbell wrote: > On Tue, 2014-11-18 at 20:03 +0000, Julien Grall wrote: >> By default, the script get_maintainer.pl will remove duplicates email as soon >> as it appends the list of maintainers of a new file, and therefore override >> the role of the developper. >> >> On complex patch (see [1]), this will result to ommitting randomly some >> maintainers. >> >> This could be fixed > > Are you proposing an alternative/better fix here? or describing what > this patch does? Describing what the patch does. >> by not removing the duplicate email in the list. Once the >> list is created, when it's necessary, the script will drop the "REST" people >> and remove duplicata. >> >> Example: >> >> Patch: https://patches.linaro.org/41083/ >> >> Before: >> >> Daniel De Graaf >> Ian Jackson >> Stefano Stabellini >> Ian Campbell >> Wei Liu >> George Dunlap >> xen-devel@lists.xen.org >> >> After: >> >> Daniel De Graaf >> Ian Jackson >> Stefano Stabellini >> Ian Campbell >> Wei Liu >> Stefano Stabellini >> Tim Deegan >> Keir Fraser >> Jan Beulich >> George Dunlap >> xen-devel@lists.xen.org >> >> [1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html >> >> Signed-off-by: Julien Grall >> CC: Don Slutz >> >> --- >> I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first >> time the script has been introduced). >> >> Developpers using this script won't ommitted to cc some maintainers, and it >> will avoid maintainers complaining about miss CC. >> >> The only drawbacks I can see is there is too much people CCed (the >> patch d67738db was intended to avoid CCing Keir too often). > > My tree doesn't have in it d67738db but from the example you give above > it seems like this patch will regress that? As someone who already gets > too much mail and is listed in THE REST these days I am very much in > favour of not mailing THE REST when other maintainers have been found. It's still the case with this patch. Before if a maintainer was both in x86 section and "THE REST". It may end up to completely drop the maintainer in the CC list. By drawbacks I meant, if there is another bug in the script then we may end up to cc too many people. Honestly I don't believe it's the case. >> Also, if the maintainers is referenced twice in the file MAINTAINERS with >> different email, the script won't notice it's duplicated and list 2 times. >> Though, for this one it could be fixed by modifying the MAINTAINERS file. >> Is it worth for Xen 4.5? For know, it seems to only happen with Stefano. > Regards. -- Julien Grall