From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrUco-0003ry-NV for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:30:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrUcg-0004sf-Us for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:30:30 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:34871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrUcg-0004rO-Ld for qemu-devel@nongnu.org; Thu, 20 Nov 2014 11:30:22 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Nov 2014 16:30:20 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 722C417D8042 for ; Thu, 20 Nov 2014 16:30:31 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sAKGUI1250528502 for ; Thu, 20 Nov 2014 16:30:18 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sAKBRQMm022274 for ; Thu, 20 Nov 2014 06:27:27 -0500 Message-ID: <546E1719.5030301@de.ibm.com> Date: Thu, 20 Nov 2014 17:30:17 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <546C8161.10100@de.ibm.com> <1416405716-21624-1-git-send-email-tumanova@linux.vnet.ibm.com> <20141119160406.7b8e0dbd.cornelia.huck@de.ibm.com> <20141120161830.GE9266@noname.redhat.com> In-Reply-To: <20141120161830.GE9266@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] geometry: fix i386 compilation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Cornelia Huck Cc: Peter Maydell , Markus Armbruster , Ekaterina Tumanova , Public KVM Mailing List , Viktor Mihajlovski , David Hildenbrand , Stefan Hajnoczi , Paolo Bonzini Am 20.11.2014 um 17:18 schrieb Kevin Wolf: > Am 19.11.2014 um 16:04 hat Cornelia Huck geschrieben: >> On Wed, 19 Nov 2014 14:40:07 +0000 >> Peter Maydell wrote: >> >>> On 19 November 2014 14:01, Ekaterina Tumanova >>> wrote: >>>> Signed-off-by: Ekaterina Tumanova >>> >>> Could you give the compiler error/warning message, please >>> (and the compiler version)? >>> >>> These changes look sensible but it's not clear to me why >>> the current code would cause a compilation failure or why >>> that would be specific to i386... >> >> This patch is referring to Kate's patch set "[PATCH v2 0/6] Geometry >> and blocksize support for backing devices", which did not compile on >> i386 (see <546C8161.10100@de.ibm.com>). > > Where does it need to be squashed in? We want to keep the tree > bisectable, so breaking the build and then fixing it at the end of the > series isn't an option. I think Kate just wanted to avoid spamming the list with v3 if only one patch is fixed up when there was no review comment about the content of the series. Using the -in-reply-to option plus a comment in the patch would have avoided the confusion - I guess. Christian