From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers Date: Thu, 20 Nov 2014 17:20:51 +0000 Message-ID: <546E22F3.40106@linaro.org> References: <1416341031-6204-1-git-send-email-julien.grall@linaro.org> <1416499682.14429.41.camel@citrix.com> <546E1389.1070304@linaro.org> <1416501018.20161.5.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XrVPa-0004Ix-VK for xen-devel@lists.xenproject.org; Thu, 20 Nov 2014 17:20:55 +0000 Received: by mail-wg0-f41.google.com with SMTP id y19so4328686wgg.14 for ; Thu, 20 Nov 2014 09:20:53 -0800 (PST) In-Reply-To: <1416501018.20161.5.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, Don Slutz List-Id: xen-devel@lists.xenproject.org On 11/20/2014 04:30 PM, Ian Campbell wrote: > On Thu, 2014-11-20 at 16:15 +0000, Julien Grall wrote: >> Hi Ian, >> >> On 11/20/2014 04:08 PM, Ian Campbell wrote: >>> On Tue, 2014-11-18 at 20:03 +0000, Julien Grall wrote: >>>> By default, the script get_maintainer.pl will remove duplicates email as soon >>>> as it appends the list of maintainers of a new file, and therefore override >>>> the role of the developper. >>>> >>>> On complex patch (see [1]), this will result to ommitting randomly some >>>> maintainers. >>>> >>>> This could be fixed >>> >>> Are you proposing an alternative/better fix here? or describing what >>> this patch does? >> >> Describing what the patch does. > > Then I think you meant "This is fixed" or "This patches fixes this > by ...". Ok. I will fix it. > >> By drawbacks I meant, if there is another bug in the script then we may >> end up to cc too many people. Honestly I don't believe it's the case. > > Sure, lets assume not. I will drop this drawbacks. Regards, -- Julien Grall