From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Thu, 20 Nov 2014 17:23:51 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: Add missing HPTE unlock Message-Id: <546E23A7.9020705@suse.de> List-Id: References: <1415150473-28458-1-git-send-email-paulus@samba.org> In-Reply-To: <1415150473-28458-1-git-send-email-paulus@samba.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras , kvm-ppc@vger.kernel.org Cc: kvm@vger.kernel.org, "Aneesh Kumar K.V" On 05.11.14 02:21, Paul Mackerras wrote: > From: "Aneesh Kumar K.V" > > In kvm_test_clear_dirty(), if we find an invalid HPTE we move on to the > next HPTE without unlocking the invalid one. In fact we should never > find an invalid and unlocked HPTE in the rmap chain, but for robustness > we should unlock it. This adds the missing unlock. > > Reported-by: Benjamin Herrenschmidt > Signed-off-by: Aneesh Kumar K.V > Signed-off-by: Paul Mackerras Thanks, applied to kvm-ppc-queue. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] KVM: PPC: Book3S HV: Add missing HPTE unlock Date: Thu, 20 Nov 2014 18:23:51 +0100 Message-ID: <546E23A7.9020705@suse.de> References: <1415150473-28458-1-git-send-email-paulus@samba.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, "Aneesh Kumar K.V" To: Paul Mackerras , kvm-ppc@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:35709 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757470AbaKTRXx (ORCPT ); Thu, 20 Nov 2014 12:23:53 -0500 In-Reply-To: <1415150473-28458-1-git-send-email-paulus@samba.org> Sender: kvm-owner@vger.kernel.org List-ID: On 05.11.14 02:21, Paul Mackerras wrote: > From: "Aneesh Kumar K.V" > > In kvm_test_clear_dirty(), if we find an invalid HPTE we move on to the > next HPTE without unlocking the invalid one. In fact we should never > find an invalid and unlocked HPTE in the rmap chain, but for robustness > we should unlock it. This adds the missing unlock. > > Reported-by: Benjamin Herrenschmidt > Signed-off-by: Aneesh Kumar K.V > Signed-off-by: Paul Mackerras Thanks, applied to kvm-ppc-queue. Alex