From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrXgm-0003Na-AH for qemu-devel@nongnu.org; Thu, 20 Nov 2014 14:46:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrXgi-0002Xg-5O for qemu-devel@nongnu.org; Thu, 20 Nov 2014 14:46:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrXgh-0002XV-Uh for qemu-devel@nongnu.org; Thu, 20 Nov 2014 14:46:44 -0500 Message-ID: <546E451F.9030102@redhat.com> Date: Thu, 20 Nov 2014 12:46:39 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416507678-15596-1-git-send-email-dslutz@verizon.com> In-Reply-To: <1416507678-15596-1-git-send-email-dslutz@verizon.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OFSlwsjjg7H5kU4vOoQv9UnDfA2NEjOse" Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v4 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost Cc: Michael Tokarev , Anthony Liguori , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OFSlwsjjg7H5kU4vOoQv9UnDfA2NEjOse Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/20/2014 11:21 AM, Don Slutz wrote: > c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 >=20 > or >=20 > c/s b154537ad07598377ebf98252fb7d2aff127983b >=20 > moved the testing of xen_enabled() from pc_init1() to > pc_machine_initfn(). >=20 > xen_enabled() does not return the correct value in > pc_machine_initfn(). >=20 > Changed vmport from a bool to an enum. Added the value "auto" to do > the old way. >=20 > Signed-off-by: Don Slutz > --- >=20 > v4: > Michael S. Tsirkin, Eric Blake, Eduardo Habkost: > Rename vmport to OnOffAuto and move to qapi/common.json > Eduardo Habkost: > Simpler convert of enum to no_vmport. > Michael S. Tsirkin: > Add assert for ON_OFF_AUTO_MAX. >=20 > hw/i386/pc.c | 23 ++++++++++++++--------- > hw/i386/pc_piix.c | 10 +++++++++- > hw/i386/pc_q35.c | 10 +++++++++- > include/hw/i386/pc.h | 2 +- > qapi/common.json | 15 +++++++++++++++ > qemu-options.hx | 8 +++++--- > vl.c | 2 +- > 7 files changed, 54 insertions(+), 16 deletions(-) I've only reviewed the qapi/common.json and qemu-options.hx files for QMP interface (and will leave the rest of the patch to others), but I'm okay with the changes to those files. I guess that means no R-b, since I didn't do a full review, so here's a weaker: Acked-by: Eric Blake if you think it is worth adding. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OFSlwsjjg7H5kU4vOoQv9UnDfA2NEjOse Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUbkUfAAoJEKeha0olJ0NqikQIAJoC9H8bCbHjxop64qxj1O4y qaesl2AJRv4jiRbjopHkX3dV0JLfaynsKO69my6Y0mTJEa5rfCX3GLzeaqEbl+pR N63bQpCiyRgkfwhUET6vzvtzFbfqHgLpd0knkcaUZdYNkQGqePwPSypCRP92KCAi juomhSW+nw8O8MC8kfSSQsw1esSRWESER6SdYFydik2PVsSCnddJHJTYdR4wO5Ci VeCM0TujtfaI6R65OFFBUphZqunXiz4HptYnbhFDE98v6Itj9krmhsZbhPIwWjVG JKU/AgWepvxHlZH2kwD3w6USKMNPRgIj1iEdeVTwUTUqsDhj3YhhjLyNoYP1h4s= =piWo -----END PGP SIGNATURE----- --OFSlwsjjg7H5kU4vOoQv9UnDfA2NEjOse--